CtrlK
BlogDocsLog inGet started
Tessl Logo
SkillPublic

code-review

从固定点(commit、branch、tag 或 merge-base)开始,按 Standards(代码是否符合本仓库记录的编码标准?)和 Spec(代码是否符合来源 issue/spec 的要求?)两个轴线审查变更。两个审查会在并行子代理中运行,并并排报告。适用于用户想审查 branch、PR、进行中的变更,或要求“review since X”时。

Quality

85%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide
SecuritybySnyk

Passed

No findings from the security scan

SKILL.md
Quality
Evals
Security

Quality

Content

81%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

An impressively actionable orchestration skill: exact commands, an early fail-fast validation gate, verbatim sub-agent briefs, and explicit handling of the no-spec case. The main cost is the inlined Fowler smell tutorial, which re-explains knowledge Claude already has and doubles as reference material that belongs in a separate file.

Suggestions

Compress the smell baseline to a bare labeled list (smell name + one-phrase cue) and keep only the two governing rules in full; drop the per-smell 'how to fix' tutorials, which Claude already knows.

Move the full smell baseline text into a references/ file (e.g. references/smell-baseline.md) and have the skill read it once when composing the Standards sub-agent prompt, keeping SKILL.md as a lean overview.

Add a one-line fallback for the aggregator (e.g., what to do if a sub-agent report exceeds the 400-word brief or returns nothing), closing the last workflow gap.

DimensionReasoningScore

Conciseness

The workflow steps and sub-agent briefs are lean, but the 12-item smell baseline explains each Fowler smell ("what it is -> how to fix", e.g. "Feature Envy:method 访问另一个 object 的 data 多于自己的 data。-> 把 method 移到它羡慕的数据上") — definitions and fixes Claude already knows. Only the selection of which smells form the baseline is novel; the per-smell tutorials could be compressed to a one-line list. Not a 2 because the inlining is explicitly justified ("sub-agent 没有其他方式读取它") and the rest of the body earns its tokens; not a 4 because ~15 of 90 lines re-teach standard refactoring knowledge.

3 / 5

Actionability

Guidance is fully executable: exact commands (`git diff <fixed-point>...HEAD`, `git log <fixed-point>..HEAD --oneline`, `git rev-parse`), a prioritized spec-discovery procedure, verbatim sub-agent briefs with word limits, and a concrete output format (## Standards / ## Spec headings plus a one-line per-axis summary). Nothing is left as vague direction.

5 / 5

Workflow Clarity

A clearly sequenced 5-step process with an explicit validation checkpoint: the fixed point must resolve and the diff be non-empty "继续前" so failures happen "而不是进入两个并行 sub-agents 后才失败". The missing-spec branch is handled explicitly (skip and report 'no spec available'). Not a 4 because the one risky point (bad ref / empty diff) has explicit fail-early validation and the degenerate cases are all addressed; the operation is read-only, so no destructive/batch cap applies.

5 / 5

Progressive Disclosure

The body is well-sectioned (流程 steps, 为什么是两条轴线) with no nested references and no dead links, and the one cross-skill mention (`/setup-matt-pocock-skills`) is clearly signaled. It falls short of 5 because the ~15-line smell baseline — static reference material the parent passes into a sub-agent prompt — is inlined in SKILL.md rather than split into a one-level-deep reference file the parent reads on demand.

4 / 5

Total

17

/

20

Passed

Description

83%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

A strong description: it explicitly states what the skill does (dual-axis review from a fixed point via parallel sub-agents) and when to use it, in third person, without padding. The main improvement room is broader trigger synonym coverage and slightly more discrete capability enumeration.

DimensionReasoningScore

Specificity

The description names concrete inputs ("commit、branch、tag 或 merge-base") and specific actions: dual-axis review (Standards/Spec each with its own question), parallel sub-agents, and side-by-side reporting. It falls short of a 5 because the actions are framed around one review pass rather than enumerating multiple discrete capabilities.

4 / 5

Completeness

Both parts are explicit: 'what' is the two-axis diff review from a fixed point with parallel sub-agents, and 'when' is the concrete "适用于..." clause listing branch, PR, in-progress changes, and 'review since X'. Not a 4 because the trigger guidance is explicit with concrete phrases rather than merely serviceable.

5 / 5

Trigger Term Quality

Natural trigger phrases are present — "审查 branch、PR、进行中的变更,或要求 'review since X' 时" — covering what a user would actually say. A few natural terms are missing (e.g., 'diff', 'pull request' spelled out, 'coding standards check'), so it does not reach comprehensive synonym coverage.

4 / 5

Distinctiveness Conflict Risk

The fixed-point + dual-axis (Standards vs Spec) framing carves a clear niche that distinguishes it from generic review skills. Minor overlap risk remains because 'review a branch/PR' is a trigger any general code-review skill would also claim.

4 / 5

Total

17

/

20

Passed

Validation

100%

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 16 / 16 Passed

Validation for skill structure

No warnings or errors.

Repository

vinvcn/mattpocock-skills-zh-CN

Path

skills/engineering/code-review/SKILL.md

Reviewed

Table of Contents

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.