finish-work

Pre-commit quality checklist covering lint, typecheck, tests, code-spec sync, API changes, database migrations, cross-layer verification, and manual testing. Blocks commit if infra or cross-layer specs lack executable depth. Use when code is written and tested but not yet committed, before submitting changes, or as a final review before git commit.

Quality

92%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide

Securityby

Passed

No findings from the security scan

Quality

Content

85%Weight 40%Scale 1-3

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

A well-structured, actionable pre-commit checklist with concrete commands, real file paths, explicit blocking gates, and clean sectioning. Its only weakness is token efficiency: a motivational 'Core Principle' section and a tangential command-relationship diagram add length without adding actionable value.

Suggestions

Remove or shrink the 'Core Principle' section ('Delivery includes not just code...') — it is motivational summary Claude already assumes and adds no actionable pre-commit guidance.

Trim the 'Relationship to Other Commands' ASCII flow diagram to a one-line pointer (e.g., 'Run before `git commit`; follow with `$record-session`') to cut ~15 lines of non-essential context.

Consider folding the 'Common Oversights' table into the relevant checklist sections so the body stays a single actionable artifact rather than checklist-plus-commentary.

Dimension	Reasoning	Score
Conciseness	The checklist core is lean and efficient, but the 'Core Principle' motivational statement ('Delivery includes not just code, but also documentation...') and the 'Relationship to Other Commands' ASCII flow diagram are non-essential context that could be tightened.	2 / 3
Actionability	Provides concrete, executable commands ('npm run lint', 'npm run typecheck', 'git diff --name-only') and specific checklist items referencing real paths and patterns (`.trellis/spec/backend/`, `console.log`, `x!`, `any`).	3 / 3
Workflow Clarity	Sequenced Quick Check Flow, explicit checklists, and a blocking validation gate ('If infra/cross-layer changed but the related spec is still abstract, do NOT finish. Run `$update-spec` manually first') with a remediation feedback loop.	3 / 3
Progressive Disclosure	No bundle files exist and none are needed; the single SKILL.md is well-organized into clearly headed, numbered sections with a coherent structure, satisfying the simple-skill allowance for well-organized content with no external references.	3 / 3
	Total	11 / 12 Passed

Description

100%Weight 40%Scale 1-3

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

A strong description: third-person, concise, and specific, with concrete enumerated actions and an explicit 'Use when' clause covering several natural trigger phrases. The breadth of covered checks (API, DB, cross-layer) introduces only mild overlap risk, well-mitigated by the commit-timing trigger.

Dimension	Reasoning	Score
Specificity	Lists multiple specific concrete actions — 'lint, typecheck, tests, code-spec sync, API changes, database migrations, cross-layer verification, and manual testing' and 'Blocks commit if infra or cross-layer specs lack executable depth' — rather than vague language.	3 / 3
Completeness	Explicitly answers both what ('Pre-commit quality checklist covering...') and when ('Use when code is written and tested but not yet committed, before submitting changes, or as a final review before git commit'), with explicit trigger guidance.	3 / 3
Trigger Term Quality	Natural phrases a user would actually say appear throughout: 'before submitting changes', 'final review before git commit', and 'not yet committed', giving good coverage of common variations.	3 / 3
Distinctiveness Conflict Risk	A clear pre-commit / final-review niche with timing-bound triggers ('before git commit', 'before submitting changes') that distinguish it from generic coding, testing, or review skills.	3 / 3
	Total	12 / 12 Passed

Validation

100%

Warnings & errors only

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 16 / 16 Passed

Validation for skill structure

No warnings or errors.

Repository: zhukunpenglinyutong/desktop-cc-gui
Path: .agents/skills/finish-work/SKILL.md
Commit: 786846c

Reviewed: 18 days ago

Table of Contents

Discovery Implementation Validation

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.