tdg-personal/python-patterns
Pythonic idioms, PEP 8 standards, type hints, and best practices for building robust, efficient, and maintainable Python applications.
48
48%
Does it follow best practices?
Impact
Pending
No eval scenarios have been run
Passed
No known issues
Quality
Discovery
32%Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.
The description identifies the Python domain and mentions specific standards (PEP 8, type hints), but reads more like a topic list than an actionable skill description. It lacks concrete action verbs describing what the skill does and entirely omits a 'Use when...' clause, making it difficult for Claude to know when to select this skill over other Python-related skills.
Suggestions
Add a 'Use when...' clause with explicit triggers, e.g., 'Use when the user asks about Python code style, PEP 8 compliance, adding type hints, or writing idiomatic Python.'
Replace the abstract noun phrases with concrete action verbs, e.g., 'Reviews and refactors Python code for PEP 8 compliance, adds type annotations, converts code to Pythonic idioms, and suggests best practices for maintainability.'
Include additional natural trigger terms users might say, such as 'code style', 'Python formatting', 'linting', 'docstrings', '.py files', or 'clean Python code'.
| Dimension | Reasoning | Score |
|---|---|---|
Specificity | Names the domain (Python) and some areas (idioms, PEP 8, type hints, best practices), but these are more like categories than concrete actions. No specific verbs describing what the skill does (e.g., 'refactors code', 'adds type annotations', 'enforces PEP 8'). | 2 / 3 |
Completeness | Describes 'what' at a high level (Python best practices and standards) but completely lacks any 'when' clause or explicit trigger guidance. Per the rubric, a missing 'Use when...' clause caps completeness at 2, and the 'what' is also weak enough to warrant a 1. | 1 / 3 |
Trigger Term Quality | Includes relevant keywords like 'PEP 8', 'type hints', 'Pythonic', and 'Python' that users might mention. However, it misses common variations like 'code style', 'linting', 'formatting', 'docstrings', 'Python conventions', or file extensions like '.py'. | 2 / 3 |
Distinctiveness Conflict Risk | Somewhat specific to Python coding standards and idioms, but could easily overlap with general Python programming skills, code review skills, or any Python-related skill. The broad phrase 'building robust, efficient, and maintainable Python applications' is quite generic. | 2 / 3 |
Total | 7 / 12 Passed |
Implementation
42%Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
This skill is a comprehensive Python best practices reference with excellent, executable code examples, but it fundamentally fails as a SKILL.md by being extremely verbose and teaching Claude things it already knows deeply. The content would be better served as a brief reminder of project-specific conventions with references to detailed sub-files, rather than a 500+ line tutorial on standard Python patterns.
Suggestions
Reduce the content by 80%+ — remove explanations of standard Python concepts (EAFP, context managers, comprehensions, decorators, type hints) that Claude already knows, and focus only on project-specific conventions or non-obvious preferences.
Split remaining content into separate reference files (e.g., TOOLING.md for pyproject.toml config, PATTERNS.md for any truly project-specific patterns) and keep SKILL.md as a concise overview with links.
Remove explanatory prose like 'Python prioritizes readability' and 'Avoid magic; be clear about what your code does' — these are basic principles Claude already follows.
If project-specific standards exist (e.g., 'always use ruff over pylint', 'use src layout'), state them as terse rules rather than teaching the underlying concepts.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | This is extremely verbose (~500+ lines) and largely teaches Claude things it already knows well: basic Python idioms, PEP 8 patterns, type hints, list comprehensions, context managers, decorators, etc. Nearly every section explains fundamental Python concepts that Claude has deep knowledge of. The 'When to Activate' section and explanatory comments like 'Python prioritizes readability' add no value. | 1 / 3 |
Actionability | The code examples are concrete, executable, and copy-paste ready throughout. Every pattern includes working Python code with good/bad comparisons, and the tooling section provides specific CLI commands and a complete pyproject.toml configuration. | 3 / 3 |
Workflow Clarity | This is primarily a reference/patterns skill rather than a multi-step workflow, so workflow clarity is less critical. However, the 'When to Activate' section lists scenarios without clear sequencing, and the tooling section lists commands without explaining when/how to chain them together or validate results. | 2 / 3 |
Progressive Disclosure | This is a monolithic wall of text with no references to external files. All content is inline in a single massive document covering 15+ topics. Content like the full pyproject.toml config, concurrency patterns, and package organization could easily be split into separate reference files with links from a concise overview. | 1 / 3 |
Total | 7 / 12 Passed |
Validation
81%Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.
Validation — 9 / 11 Passed
Validation for skill structure
| Criteria | Description | Result |
|---|---|---|
skill_md_line_count | SKILL.md is long (751 lines); consider splitting into references/ and linking | Warning |
frontmatter_unknown_keys | Unknown frontmatter key(s) found; consider removing or moving to metadata | Warning |
Total | 9 / 11 Passed | |
Reviewed
Table of Contents