Content
92%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A highly operational skill body: every step carries exact, copy-pasteable git/gh commands, validation stops and failure paths are explicit at each stage, and the skill defers to authoritative repo files (PR template, CI title config) instead of duplicating them. The only blemish is minor over-explanation — conventional-commit type definitions and a few justificatory parentheticals — that could be trimmed for token efficiency.
Suggestions
Trim the change-type table's "When" column: simply list the repo's allowed types (feat, fix, refactor, chore, test) and defer to `.github/workflows/check_pr_title.yml` for the authoritative definitions, since Claude already knows standard conventional-commit semantics.
Cut rationale parentheticals such as "(so they know where to find it if they want to review later)" and "it changes, and a stale copy silently drops checklist items" — the imperatives are enough; keep only the stale-template warning as a short 'Do not reproduce the template from memory' instruction.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is efficient and nearly every token is repo-specific operational knowledge (the module mapping table, filename conventions, exact commands), so it is well above the 'mostly efficient but some unnecessary explanation' anchor. However, there are minor instances of over-explanation that could be trimmed: the change-type table defines standard conventional-commit types Claude already knows ("`feat` | New functionality", "`fix` | Bug fix", "`refactor` | Same behavior, better structure"), and a few parenthetical rationales ("(so they know where to find it if they want to review later)", "it changes, and a stale copy silently drops checklist items") that assume less competence than warranted. That places it at the 'efficient; minor instances of over-explanation that could be trimmed' anchor rather than the lean score-5 anchor where every token earns its place. | 4 / 5 |
Actionability | The guidance is fully executable with copy-paste-ready commands for every step — "git branch --show-current", "gh pr view --json number,title,body 2>/dev/null", "git diff main...HEAD", "tail -n +3 .pr-drafts/<branch-name>.md > /tmp/pr-body.md", "gh pr create --base <base-branch> --title \"<title>\" --body-file /tmp/pr-body.md" — and covers both the new-PR and existing-PR cases plus a concrete worked example of the draft file format ("[model] feat: add support for Qwen4"). This matches the top anchor: specific commands covering the common cases with no gaps. | 5 / 5 |
Workflow Clarity | The four-step sequence is clearly ordered with explicit validation checkpoints and feedback loops throughout: "If on `main` — stop and ask the user", "If `make quality` fails: stop and report errors", "If the branch has no commits ahead of `main`, stop — nothing to open a PR for", "A `risky` verdict stops the PR: report it and wait for the user", and "Must pass the regex in `.github/workflows/check_pr_title.yml`". Error-recovery paths are enumerated (commit-or-proceed decision branch, rejected module name → read the authoritative workflow file). This matches the top anchor: clear sequence, explicit validation, feedback loops, and checklists for a complex process. | 5 / 5 |
Progressive Disclosure | No bundle files exist (references/, scripts/, assets/ are absent), and the skill structures itself well as a single-level procedure: clearly headed sections (Interaction Principle, Steps 1–4, Common Pitfalls), with hot-path lookup tables kept inline and heavier material correctly deferred to well-signaled external sources — ".github/PULL_REQUEST_TEMPLATE.md" ("Do not reproduce the template from memory"), ".github/workflows/check_pr_title.yml" ("The authoritative module and type lists live in..."), and the `/veomni-review` and `/veomni-develop` skills. Nothing inlined clearly belongs in a separate file, references are one level deep with read-when guidance, and navigation is easy via numbered steps and tables — matching the top anchor for appropriate splitting and easy navigation rather than the score-4 anchor with organization gaps. | 5 / 5 |
Total | 19 / 20 Passed |