Content
92%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
The body is an outstanding example of a workflow skill: lean, entirely non-generic, and organized into five well-sequenced phases with explicit validation commands, failure contracts, and a pitfalls checklist. Its only weakness is that a few implementation steps (model wiring via `VeomniOp`/`resolve_op_impl`, device-package guards, raw forward/backward signatures) are named but never shown in code, leaving minor actionability gaps.
Suggestions
Add a short raw-pair example showing the forward/backward signature (returning `(output, SavedState)` and one gradient per positional tensor input), since Phase 1/2 rely on it but only describe it in prose.
Include a minimal model-integration snippet showing `VeomniOp(resolve_op_impl(...))` construction and storage on the module, mirroring the existing register_op example.
Show the canonical guard-plus-requirement pattern for optional device packages (e.g., the NPU/CUDA import guard), which the pitfalls call out but the implement steps never demonstrate.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is dense, imperative, and entirely repo-specific (registry identity tuples, `SavedState` contracts, patchgen rules, NPU workflow entries); it explains nothing Claude already knows and contains no padded or motivational prose. Every section earns its place, matching the 'lean and efficient' anchor rather than the 4 anchor's 'minor instances of over-explanation'. | 5 / 5 |
Actionability | Most guidance is executable and specific: a copy-paste-ready `register_op(...)` example with `GpuKernelRequirement(platforms=(NvidiaGpuPlatform(min_cc=80),))`, a concrete `pytest -q tests/ops/<kernel_name>/ tests/ops/base/` command, `make quality`, and `OP_REGISTRY.list_registered(...)`. It falls short of the 5 anchor because several steps name APIs without any example — e.g., constructing "a `VeomniOp` from `resolve_op_impl(...)`", the raw `forward`/`backward` pair's signature, and the pattern for guarding optional device packages are prose-only. | 4 / 5 |
Workflow Clarity | The five phases (Design → Implement → Test → Document → Finalize) form a clear sequence with explicit validation checkpoints: "Run the family tests plus the registry and documentation guards", the finalize checklist ("Run `/veomni-review`", "Run `make quality`", "Verify `OP_REGISTRY.list_registered(...)`"), and a failure contract ("must fail clearly when its requirement is not satisfied; it must not silently fall back to eager"). Together with the Common Pitfalls checklist this matches the 5 anchor's explicit validation and checklist criteria, not merely the 4 anchor's 'most checkpoints'. | 5 / 5 |
Progressive Disclosure | There are no bundle files (references/, scripts/, assets/ are absent), so the skill is judged on its own structure: well-organized sections (Before You Start, Ops Architecture, Phases 1–5, Common Pitfalls) with pointers to repo documentation clearly signaled one level deep (`.agents/knowledge/constraints.md`, `veomni/ops/README.md`, `docs/design/op_selection.md`). At ~140 lines of cohesive procedural guidance, nothing here clearly belongs in a separate file, so it does not drop to the 4 anchor's 'minor organization gaps'. | 5 / 5 |
Total | 19 / 20 Passed |