Content
88%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
This is a high-quality, deeply project-specific skill body: it sequences the work into five phases with concrete registration code, exact paths, and real validation steps, and its Common Pitfalls section captures subtle failure modes (lazy factories, async wrapper coverage, NPU import guards). The main improvements are tightening the inline architecture/ directory-tree material — either trimming it or moving it to a reference file — and consolidating the repeated pointers to the design docs.
Suggestions
Move the VeOmni Ops Architecture section (directory tree plus the three-mechanism comparison) into a reference file (e.g. references/architecture.md) and keep a short decision summary in SKILL.md, improving both conciseness and progressive disclosure.
Consolidate the repeated pointers to docs/design/kernel_selection.md and unified_kernel_registry.md (currently referenced in Before You Start, Phase 1, and Phase 4) into one clearly signaled location.
Trim per-directory comments in the kernels/ tree to the few directories a new-op author will actually touch, cutting tokens without losing actionable context.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is dense with project-specific knowledge Claude cannot know (registry mechanics, dispatch precedence, NPU guards, CI file quirks) and wastes almost no tokens on general concepts. Minor over-explanation remains — e.g., the full kernels/ subtree listing with per-directory comments and the repeated design-doc pointers across sections — keeping it at 'minor instances of over-explanation that could be trimmed' rather than the lean level-5 anchor. | 4 / 5 |
Actionability | Guidance is copy-paste ready: a complete KernelSpec registration example ("KERNEL_REGISTRY.register(KernelSpec(name=..., op_name=..., variant=..., factory=..., hardware=...))"), the matching OpSlot declaration ("veomni_my_op = OpSlot(\"my_op\", \"standard\")"), concrete commands ("pytest tests/ops/ -v", "make quality"), exact file paths, and pointers to live examples (rotary/__init__.py, rms_norm/__init__.py). This matches 'Fully executable; copy-paste ready code or commands' covering the common cases. | 5 / 5 |
Workflow Clarity | Five clearly sequenced phases (Design → Implement → Test → Document → Finalize) with explicit validation checkpoints: run "pytest tests/ops/ -v", then "make quality", verify "KERNEL_REGISTRY.dump()" and OpSlot rebinding, and run "/veomni-review" before the PR. The Common Pitfalls section supplies error-recovery guidance for each failure mode ('the variant is invisible to _bind_veomni_ops()... you'll silently exercise the wrong kernel'), matching the level-5 anchor with validation steps and error feedback. | 5 / 5 |
Progressive Disclosure | Structure is good: well-labeled phases, a clear decision guide for the three dispatch mechanisms, and clearly signaled one-level-deep pointers to deeper material (docs/design/kernel_selection.md, unified_kernel_registry.md, veomni/ops/README.md, .agents/knowledge/). However, the ~70-line inline architecture overview and directory tree are content that could live in a separate reference file, which is the 'minor organization gaps' of level 4 rather than the well-split level-5 anchor. | 4 / 5 |
Total | 18 / 20 Passed |