merging-devtools-module

Workflow for merging a DevTools submodule into its parent module. Covers BUILD.gn consolidation and updating devtools_grd_files.gni.

Quality

69%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide

Securityby

Passed

No findings from the security scan

Fix and improve this skill with Tessl

tessl review fix ./.agents/skills/merging-devtools-module/SKILL.md

Quality

Content

68%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

The body is a well-structured, actionable workflow with excellent before/after GN examples and no conceptual padding. Its main gaps are the missing verification step after destructive edits (delete BUILD.gn, strip grd_files entries) and the unbarrelify section's reliance on an external repo rather than in-skill commands. Adding a build-verification checkpoint would raise the workflow's reliability.

Suggestions

Add an explicit validation step after the destructive edits, e.g., "5. Verify: run `autoninja -C out/Default` (or the project's build command) and fix any missing sources/deps before proceeding", with a fix-and-retry loop.

Replace the placeholder `rm <child_module_path>/BUILD.gn` with the concrete example path used later (`front_end/panels/timeline/extensions/BUILD.gn`) so the workflow section is copy-paste ready on its own.

Include a one-line unbarrelify usage command (e.g., install and invocation) in the skill instead of deferring entirely to the external repository, so the barrel-removal step is executable without a context switch.

Dimension	Reasoning	Score
Conciseness	The body is efficient: no explanations of concepts Claude already knows, steps are imperative, and the before/after GN snippets are tightly scoped. Minor trimmable padding exists ("This is highly recommended to complete the refactoring process efficiently", the opening goal paragraph), keeping it below the lean anchor 5.	4 / 5
Actionability	Concrete guidance dominates: exact paths ("config/gni/devtools_grd_files.gni"), a real rm command, and complete before/after GN diffs. Not 5 because "rm <child_module_path>/BUILD.gn" is a placeholder and the unbarrelify section defers entirely to an external repository instead of giving runnable commands.	4 / 5
Workflow Clarity	Steps 1-4 are clearly sequenced and reinforced by a worked example, but the workflow includes destructive operations (deleting the child BUILD.gn, removing entries from the global .gni) with no validation step such as running the build to confirm nothing broke. Per the rubric cap, destructive/batch operations without validation cap workflow clarity at 3.	3 / 5
Progressive Disclosure	No bundle files exist, and the body is organized into clear, well-ordered sections (Prerequisites, Workflow Steps, Example, Removing Barrel Files) with the worked example appropriately scoped. Not 5 because the ~90-line worked example is inline content that could live in a separate reference file if the skill grows.	4 / 5
	Total	15 / 20 Passed

Description

53%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

The description is specific, third-person, and free of fluff, clearly stating what the skill does within a well-defined DevTools build-system niche. Its main weakness is the complete absence of a "Use when..." clause or trigger guidance, which caps completeness and limits natural trigger-term coverage. Adding an explicit trigger clause would lift the two heaviest-weighted dimensions.

Suggestions

Add a trigger clause, e.g.: "Use when merging or inlining a DevTools submodule (e.g., panels/timeline/extensions) into its parent module, or when asked to consolidate BUILD.gn files or update devtools_grd_files.gni."

Broaden natural trigger terms with synonyms users would actually say, such as "merge", "inline", "consolidate", and "parent module", rather than relying only on technical file names.

Mention the full action set (merge sources/deps, delete the child BUILD.gn, update grd_files lists, remove barrel files) so the description comprehensively covers what the body delivers.

Dimension	Reasoning	Score
Specificity	The description names the domain ("merging a DevTools submodule into its parent module") and two concrete actions ("BUILD.gn consolidation and updating devtools_grd_files.gni"), matching the 1-2 concrete actions anchor. Not 4 because it omits several other actions the skill covers (deleting the child BUILD.gn, removing barrel files).	3 / 5
Completeness	The "what" is clear and concrete, but there is no "Use when..." clause or equivalent trigger guidance anywhere in the description, which caps completeness at 3 per the judging guidelines. Not 4 because the "when" is entirely absent rather than merely weakly implied.	3 / 5
Trigger Term Quality	Relevant keywords are present ("DevTools", "submodule", "BUILD.gn", "devtools_grd_files.gni") but common natural variations users might say ("merge into parent", "inline module", "remove submodule") are missing. Not 4 because keyword coverage is adequate rather than good, and no synonyms or file-extension variations appear.	3 / 5
Distinctiveness Conflict Risk	The niche is highly specific (DevTools GN build consolidation, a named .gni file), giving minimal conflict risk with other skills. It sits between anchor 3 (could overlap with similar skills) and anchor 5 (clear niche with distinct triggers) because the niche is distinct but the description provides no explicit trigger phrasing.	4 / 5
	Total	13 / 20 Passed

Validation

100%

Warnings & errors only

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 16 / 16 Passed

Validation for skill structure

No warnings or errors.

Repository: ChromeDevTools/devtools-frontend
Path: .agents/skills/merging-devtools-module/SKILL.md
Commit: de3f9ca

Reviewed: 9 days ago

Table of Contents

Discovery Implementation Validation

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.