Content
85%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A strong, expert-calibrated reference skill: terse non-obvious rules, a fully validated workflow with repair loops, and exemplary reference navigation. The only improvements are minor: trim the generic loader-policy boilerplate, and the absence of any inline example means the body alone is not fully copy-paste ready.
Suggestions
Trim or shorten the generic 'Loading companion skills' paragraph — it is host boilerplate unrelated to baseLanguage specifics and consumes ~90 tokens of context.
Inline one minimal ready-to-paste JSON blueprint (e.g. a LocalVariableDeclarationStatement or InstanceMethodCallOperation) in the body so the most common constructs are executable without opening references/json-patterns.md.
Split the long Compatibility bullet into separate bullets for blueprint Java-7 limits vs. parser lambda handling, and verify all seven referenced files (references/concept-mapping.md, json-patterns.md, critical-rules.md, parse-java-tips.md, stub-references.md, json-ast-workflow.md, troubleshooting.md) actually ship with the skill bundle — none were present to verify here.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is dense and expert-only — every directive states a non-obvious MPS rule (":eq: instead of ==", "ConstructorDeclaration.returnType MUST be a VoidType node") with no padding or explanation of concepts Claude already knows. Two minor trimmable spots keep it below anchor 5: the ~90-word generic "Loading companion skills" loader-policy paragraph, and the long Compatibility bullet that packs three distinct topics (blueprint Java-7 limits, parser lambda handling, records) into one passage. | 4 / 5 |
Actionability | Guidance is highly concrete — exact tool names and flags ("mps_mcp_update_node", "dryRun: true", "mps_mcp_alter_nodes FIX_REFERENCES"), exact concepts/roles ("NPEEqualsExpression", "ClassCreator.baseMethodDeclaration", "LocalVariableDeclarationStatement"), and a precise placeholder-swap strategy. It falls short of anchor 5 only because copy-paste-ready examples (JSON blueprints, Java snippets) are deferred to the reference files rather than shown inline for the most common constructs. | 4 / 5 |
Workflow Clarity | The Common Workflow gives a clearly sequenced 8-step process with an explicit three-gate validation ("dryRun: true… mps_mcp_check_root_node_problems — semantic checking… mps_mcp_alter_nodes MAKE — generation + compilation") and a feedback loop for error recovery ("run mps_mcp_alter_nodes FIX_REFERENCES rather than re-harvesting"). This matches the anchor for clear sequence with explicit validation steps and error-recovery loops, including the tool-choice decision guidance in Choose Your Path. | 5 / 5 |
Progressive Disclosure | The body is a true overview: critical rules inline, and a Reference Index where each of the seven reference files is one level deep and explicitly signaled with a when-to-open trigger ("Open references/json-patterns.md when you need ready-to-paste JSON blueprints…"). Note: no references/ directory was present in the review bundle, so the referenced files' existence could not be verified; the structural organization itself fully matches the anchor for a clear overview with well-signaled one-level-deep references. | 5 / 5 |
Total | 18 / 20 Passed |