Content
88%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A well-engineered, highly actionable skill: every step has executable commands, and edge cases (branch-only reviews, failed lookups, huge diffs, multiple matching PRs) are handled with explicit fallback and recovery paths. The only meaningful improvements are trimming the redundant commands/examples sections and moving the lengthy crypto/agent-infra policy into one-level-deep reference files.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is efficient: concrete commands with terse bullets, no explanations of concepts Claude already knows (it never explains what a PR or git diff is), and the dense sections (issue acceptance, concern formatting, crypto/agent-infra policy) convey repo-specific rules Claude could not infer. Minor trim opportunities exist — the 'Useful Commands Reference' table and 'Example Usage' section largely restate commands and steps already fully specified in Steps 1–4 — which fits 'efficient; minor instances of over-explanation that could be trimmed' rather than the lean score-5 anchor. | 4 / 5 |
Actionability | Guidance is fully executable throughout: copy-paste-ready commands for every step ('gh pr list --head "<branch>" --state open', 'gh pr view <number> --json title,body,...', 'gh pr diff <number>', 'git fetch origin main <branch>' / 'git diff origin/main...origin/<branch>', 'gh api repos/OWNER/REPO/collaborators/AUTHOR/permission --jq .permission'), a concrete output template, and worked examples covering the two common input cases (PR number, branch name). | 5 / 5 |
Workflow Clarity | Steps 1–5 are clearly sequenced with explicit validation and error-recovery branches: ambiguous input (multiple PRs → ask the user), PR-resolution outcomes (one / many / none), command failure ('gh pr diff' fails → local git diff fallback; branch-only → diff against main), oversized diffs (chunk via the Task tool, merge summaries), and failed issue lookups ('Report failed lookups as unverified and continue the code review'). This matches the anchor requiring explicit validation steps and feedback loops; the operation is read-only, so the destructive-operation cap does not apply. | 5 / 5 |
Progressive Disclosure | No bundle files (references/, scripts/, assets/) exist, and the single file is well organized into clearly signaled sections (Prerequisites, Steps 1–5, commands table, examples) with no nested-reference chains — good structure with most content appropriately placed inline. It falls short of the score-5 anchor because the self-contained 200-line body includes sizable specialized policy (crypto boundaries, agent-infra consistency) that could live in one-level-deep reference files, and the one external link ('../../../crates/openshell-crypto/CRYPTO.md') plus the named 'sync-agent-infra maintenance map' point outside the skill bundle without bundled copies. | 4 / 5 |
Total | 18 / 20 Passed |