Content
88%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
This is a high-quality, operational skill body: copy-paste-ready commands throughout, an explicit dry-run-first workflow with validation and feedback loops for a batch-rewrite tool, and well-signaled one-level-deep references. The only notable defects are deliberate-but-token-costly repetition of the core invariants and two referenced install scripts that are absent from the bundle.
Suggestions
Ship the referenced install.sh and install.ps1 (or drop the claims about them and point to references/install.md), since the body and the helper's error hints both direct the user to files that do not exist.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is dense and tool-specific with no explanations of concepts Claude already knows — every section teaches ast-grep behavior (wildcards, two-pass writes, --lang inference), fitting 'efficient; minor instances of over-explanation that could be trimmed'. It falls short of 5 because the critical gotchas (two-pass trick, regex misuse, single-quoting) are each restated two to three times across 'Three things', the helper sections, and 'Invariants'. | 4 / 5 |
Actionability | Every section delivers copy-paste-ready commands: 'python scripts/ast_grep_helper.py search 'console.log($MSG)' --lang ts src/', 'sg run -p ... -r ... --update-all src/', plus documented flags (--globs, -C, --json-out) and concrete debug idioms like '--debug-query=ast --stdin <<< ...'. Examples cover search, dry-run replace, apply, scan, validate, and the 0-match debugging path. | 5 / 5 |
Workflow Clarity | The rewrite workflow is an explicit numbered sequence with validation and a feedback loop — search to confirm, dry-run, inspect the summary, 'If wrong: refine pattern, go back to step 1', then --apply, followed by 'git diff --stat' review — which is exactly the anchor-5 pattern. The 0-match section adds a prioritized diagnostic loop with error recovery ('Do not blindly retry'), satisfying the batch/destructive-operation validation requirement. | 5 / 5 |
Progressive Disclosure | Structure is strong: a prioritized 'Required reading' list gives each of the 7 reference files a one-level-deep pointer with explicit read-when conditions, and the scripts/ helper is real and matches the body's claims. It misses 5 because the body references 'install.sh (POSIX) and install.ps1 (Windows)' as shipped platform scripts, but neither file exists in the bundle — a broken reference the helper script also points to. | 4 / 5 |
Total | 18 / 20 Passed |