CtrlK
BlogDocsLog inGet started
Tessl Logo

1k-code-quality

Code quality standards — lint (oxlint), format (oxfmt), type check (tsc), pre-commit hooks, and comment conventions. All comments must be in English.

55

Quality

63%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide

SecuritybySnyk

Passed

No findings from the security scan

Fix and improve this skill with Tessl

tessl review fix ./.skillshare/skills/1k-code-quality/SKILL.md
SKILL.md
Quality
Evals
Security

Quality

Content

61%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

The body is well-structured and highly actionable with concrete commands and code patterns, and it correctly points to real one-level-deep reference files. Its main weaknesses are duplicated content between the body and references and a lack of explicit validation checkpoints in the pre-commit workflow.

Suggestions

De-duplicate the body against references/rules/code-quality.md: keep a concise summary in SKILL.md and move the full Lint Fixes / Language Requirements / When to Comment / Development Principles detail into the reference.

Add an explicit validation checkpoint to the Pre-Commit Workflow (e.g. 'Run yarn agent:check --profile commit; only commit if it reports 0 errors; if it fails, open the reported log path and fix before re-running').

Trim the legacy ESLint warning paragraph or move it into the fix-lint reference so the overview stays lean.

DimensionReasoningScore

Conciseness

Mostly efficient with concrete code blocks, but the body re-inlines substantial material (Common Lint Fixes, Language Requirements, When to Comment, Development Principles) that is duplicated in references/rules/code-quality.md, so it could be tightened.

3 / 5

Actionability

Provides concrete executable commands (yarn agent:check, npx oxlint ...) and copy-paste-ready good/bad code patterns, but the examples are illustrative patterns rather than complete runnable scripts, leaving minor gaps.

4 / 5

Workflow Clarity

A pre-commit sequence is implied via 'yarn agent:check --profile commit' and a checklist exists, but there is no multi-step workflow with explicit validation checkpoints in the body; the only checkpoint is the command 'passes'.

3 / 5

Progressive Disclosure

Good section structure with clearly signaled, one-level-deep references to real files (references/rules/code-quality.md, references/rules/fix-lint.md) plus bullet previews; the main gap is the duplicated inline content that arguably belongs only in the references.

4 / 5

Total

14

/

20

Passed

Description

66%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

The description clearly states what the skill covers and names specific tools, but omits any explicit 'Use when' trigger guidance, which limits its discoverability and caps completeness. It is mostly distinct thanks to the toolchain specifics.

Suggestions

Add an explicit trigger clause, e.g. 'Use when running lint/format/type checks, setting up pre-commit hooks, or writing comments in the OneKey codebase.'

Lead with the primary action verbs (e.g. 'Lints, formats, and type-checks code') rather than the abstract noun 'Code quality standards' to strengthen specificity.

Include natural user phrasings like 'fix lint errors' or 'check code before commit' to improve trigger-term coverage.

DimensionReasoningScore

Specificity

Names the domain and several concrete tools/areas ('lint (oxlint), format (oxfmt), type check (tsc), pre-commit hooks, and comment conventions'), but frames them as tool categories rather than the multiple distinct concrete actions needed for a 5.

4 / 5

Completeness

Has a clear 'what' (code quality standards across lint/format/type-check/comments) but no explicit 'when'/'Use when' trigger clause, which caps completeness at 3 per the rubric guideline.

3 / 5

Trigger Term Quality

Includes natural terms users would say ('lint', 'format', 'type check', 'pre-commit hooks', 'code quality') with specific tool names, but a few common phrasings like 'lint my code' or 'fix lint errors' are not present.

4 / 5

Distinctiveness Conflict Risk

The OneKey-specific toolchain (oxlint/oxfmt/tsc, agent:check) gives it a clear niche with minimal conflict risk, though 'code quality' broadly could overlap with general coding-patterns skills.

4 / 5

Total

15

/

20

Passed

Validation

81%

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation13 / 16 Passed

Validation for skill structure

CriteriaDescriptionResult

allowed_tools_field

'allowed-tools' contains unusual tool name(s)

Warning

relative_links

Relative link issues: 2 deeper-than-1-level

Warning

referenced_paths_exist

Referenced path issues: 2 deeper-than-1-level

Warning

Total

13

/

16

Passed

Repository
OneKeyHQ/app-monorepo
Reviewed

Table of Contents

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.