Name: 1k-code-quality
Rating: 54.400000000000006 (1 reviews)
Author: OneKeyHQ

1k-code-quality

Code quality standards — lint (eslint/oxlint), type check (tsc), pre-commit hooks, and comment conventions. All comments must be in English.

Quality

62%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide

Securityby

Passed

No findings from the security scan

Fix and improve this skill with Tessl

tessl review fix ./.skillshare/skills/1k-code-quality/SKILL.md

Quality

Content

65%

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

The body is highly actionable with concrete commands and code examples and references real bundle files, but it duplicates reference content inline and delegates the lint-fix feedback loop to a referenced file rather than embedding it.

Suggestions

Trim the inline 'Single Responsibility' and 'Avoid Over-Abstraction' sections — concepts Claude already knows — and point to code-quality.md for the rationale, keeping only project-specific conventions inline.

Add an explicit fix→re-run loop in the body (e.g. 'If agent:check fails, read the reported path, apply the matching fix below, then re-run') instead of only delegating to fix-lint.md.

De-duplicate the 'Lint Commands' and 'Language Requirements' blocks against code-quality.md so the body stays a lean overview and the reference holds the detail.

Dimension	Reasoning	Score
Conciseness	The body is mostly efficient with project-specific commands and tight ✅/❌ examples, but the 'Single Responsibility' and 'Avoid Over-Abstraction' sections explain concepts Claude already knows and duplicate material in the reference, fitting 'mostly efficient but could be tightened'.	2 / 3
Actionability	Provides fully executable, copy-paste-ready commands ('yarn agent:check --profile commit', 'yarn lint:only') and concrete code fixes (underscore prefixes, 'void'/'await' for floating promises), matching 'fully executable code/commands; copy-paste ready'.	3 / 3
Workflow Clarity	A pre-commit gate and a code-quality checklist give a sequence with validation, but the fix→re-run feedback loop is delegated to fix-lint.md rather than stated in the body, matching 'steps listed but validation gaps; checkpoints implicit'.	2 / 3
Progressive Disclosure	References to code-quality.md and fix-lint.md are clearly signaled one level deep with content summaries (and the files exist), but substantial inline content (lint commands, language requirements, dev principles) duplicates code-quality.md, fitting 'content that should be separate is inline'.	2 / 3
	Total	9 / 12 Passed

Description

60%

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

The description is specific and action-oriented with concrete tooling, but lacks an explicit 'Use when…' trigger clause and natural trigger-term coverage, capping completeness and trigger quality at 2.

Suggestions

Add an explicit 'Use when…' trigger clause, e.g. 'Use when fixing lint/type errors, setting up pre-commit checks, or enforcing English comment conventions.'

Broaden trigger terms to natural user phrasings like 'lint errors', 'type errors', 'fix lint warnings', 'pre-commit hook fails'.

Sharpen distinctiveness by leading with the project-specific gate ('yarn agent:check') so it is clearly tied to the OneKey workflow rather than generic code quality.

Dimension	Reasoning	Score
Specificity	Lists multiple concrete actions with named tooling — 'lint (eslint/oxlint)', 'type check (tsc)', 'pre-commit hooks', 'comment conventions' — matching the 'lists multiple specific concrete actions' anchor.	3 / 3
Completeness	It clearly states what the skill does but provides no explicit 'when should Claude use it' trigger; per the guideline a missing 'Use when…' clause caps completeness at 2.	2 / 3
Trigger Term Quality	Terms like 'lint', 'type check', 'pre-commit hooks' are relevant, but there is no natural 'Use when…' phrasing and common user variations are missing, fitting 'some relevant keywords but missing common variations'.	2 / 3
Distinctiveness Conflict Risk	The named tooling (eslint/oxlint, tsc, agent:check) narrows the niche, but 'code quality standards' is broad and could overlap with general coding skills, matching 'somewhat specific but could still overlap'.	2 / 3
	Total	9 / 12 Passed

Validation

81%

Warnings & errors only

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 13 / 16 Passed

Validation for skill structure

Criteria	Description	Result
allowed_tools_field	'allowed-tools' contains unusual tool name(s)	Warning
relative_links	Relative link issues: 2 deeper-than-1-level	Warning
referenced_paths_exist	Referenced path issues: 2 deeper-than-1-level	Warning

	Total	13 / 16 Passed

Repository: OneKeyHQ/app-monorepo
Path: .skillshare/skills/1k-code-quality/SKILL.md
Commit: d71e6b7

Reviewed: about 5 hours ago

Table of Contents

Discovery Implementation Validation

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.