Content
75%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A highly actionable standards skill: every command and code example is executable and the key lint-fix patterns are concrete and complete. Its weaknesses are redundancy — several sections duplicate references/rules/code-quality.md nearly verbatim and the body never closes the loop on what to do when agent:check fails — which cost it conciseness and keep progressive disclosure and workflow clarity just below top marks.
Suggestions
Trim the duplicated sections (Common Lint Fixes, Language Requirements, When to Comment, Development Principles) to one-line summaries pointing at references/rules/code-quality.md, keeping only the most common fix pattern inline.
Close the error-recovery loop explicitly: after "yarn agent:check --profile commit", add "If it fails, follow the workflow in references/rules/fix-lint.md, then re-run until it passes."
Merge the "Pre-Commit Workflow" section into "Lint Commands" — it repeats a command already listed with the same comment.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Line-by-line the body is tight (commands with one-line comments, terse code examples), but roughly half of it — "Common Lint Fixes", "Language Requirements", "When to Comment", and the two "Development Principles" sections — is duplicated nearly verbatim in references/rules/code-quality.md, and the "Pre-Commit Workflow" section repeats a command already shown in "Lint Commands". This matches anchor 3's 'mostly efficient but could be tightened' rather than anchor 2, since there is little conceptual over-explanation, only redundant material. | 3 / 5 |
Actionability | The body gives copy-paste-ready commands ("yarn agent:check --profile commit", "npx oxlint --tsconfig ./tsconfig.json --type-aware ... --deny-warnings") and executable before/after examples covering the common cases (unused vars/params, floating promises, English comments, gas-limit and fee comments, spellcheck skip-list grep/echo). This matches anchor 5's 'fully executable; copy-paste ready; specific examples cover the common cases'. | 5 / 5 |
Workflow Clarity | The usage guidance is unambiguous — "always use yarn agent:check first; use lower-level commands only when debugging" — with a pre-commit checklist ("yarn agent:check --profile commit passes") serving as a validation gate, matching anchor 4. It falls short of anchor 5 because the body has no error-recovery loop of its own: when agent:check fails, the fix-and-reverify workflow lives only in the referenced fix-lint.md, and the body never explicitly says 'if it fails, follow references/rules/fix-lint.md then re-run'. | 4 / 5 |
Progressive Disclosure | The bundle structure is good: two real, one-level-deep reference files (references/rules/code-quality.md, references/rules/fix-lint.md), both clearly signaled in a "Detailed Guides" section with bullet summaries of their contents, matching anchor 4. It does not reach anchor 5 because the body inlines ~100 lines that duplicate code-quality.md instead of being a lean overview that defers detail to the reference — the duplication noted under conciseness is an organization gap beyond 'minor'. | 4 / 5 |
Total | 16 / 20 Passed |