CtrlK
BlogDocsLog inGet started
Tessl Logo

1k-code-quality

Code quality standards — lint (oxlint), format (oxfmt), type check (tsc), pre-commit hooks, and comment conventions. All comments must be in English.

59

Quality

70%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide

SecuritybySnyk

Passed

No findings from the security scan

Fix and improve this skill with Tessl

tessl review fix ./.skillshare/skills/1k-code-quality/SKILL.md
SKILL.md
Quality
Evals
Security

Quality

Content

75%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

A highly actionable standards skill: every command and code example is executable and the key lint-fix patterns are concrete and complete. Its weaknesses are redundancy — several sections duplicate references/rules/code-quality.md nearly verbatim and the body never closes the loop on what to do when agent:check fails — which cost it conciseness and keep progressive disclosure and workflow clarity just below top marks.

Suggestions

Trim the duplicated sections (Common Lint Fixes, Language Requirements, When to Comment, Development Principles) to one-line summaries pointing at references/rules/code-quality.md, keeping only the most common fix pattern inline.

Close the error-recovery loop explicitly: after "yarn agent:check --profile commit", add "If it fails, follow the workflow in references/rules/fix-lint.md, then re-run until it passes."

Merge the "Pre-Commit Workflow" section into "Lint Commands" — it repeats a command already listed with the same comment.

DimensionReasoningScore

Conciseness

Line-by-line the body is tight (commands with one-line comments, terse code examples), but roughly half of it — "Common Lint Fixes", "Language Requirements", "When to Comment", and the two "Development Principles" sections — is duplicated nearly verbatim in references/rules/code-quality.md, and the "Pre-Commit Workflow" section repeats a command already shown in "Lint Commands". This matches anchor 3's 'mostly efficient but could be tightened' rather than anchor 2, since there is little conceptual over-explanation, only redundant material.

3 / 5

Actionability

The body gives copy-paste-ready commands ("yarn agent:check --profile commit", "npx oxlint --tsconfig ./tsconfig.json --type-aware ... --deny-warnings") and executable before/after examples covering the common cases (unused vars/params, floating promises, English comments, gas-limit and fee comments, spellcheck skip-list grep/echo). This matches anchor 5's 'fully executable; copy-paste ready; specific examples cover the common cases'.

5 / 5

Workflow Clarity

The usage guidance is unambiguous — "always use yarn agent:check first; use lower-level commands only when debugging" — with a pre-commit checklist ("yarn agent:check --profile commit passes") serving as a validation gate, matching anchor 4. It falls short of anchor 5 because the body has no error-recovery loop of its own: when agent:check fails, the fix-and-reverify workflow lives only in the referenced fix-lint.md, and the body never explicitly says 'if it fails, follow references/rules/fix-lint.md then re-run'.

4 / 5

Progressive Disclosure

The bundle structure is good: two real, one-level-deep reference files (references/rules/code-quality.md, references/rules/fix-lint.md), both clearly signaled in a "Detailed Guides" section with bullet summaries of their contents, matching anchor 4. It does not reach anchor 5 because the body inlines ~100 lines that duplicate code-quality.md instead of being a lean overview that defers detail to the reference — the duplication noted under conciseness is an organization gap beyond 'minor'.

4 / 5

Total

16

/

20

Passed

Description

66%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

A concise, tool-specific description that clearly states what the skill governs, anchored by concrete tool names (oxlint, oxfmt, tsc). Its main weakness is the complete absence of a "Use when..." trigger clause, which caps completeness, and it lacks natural trigger variations like "lint warnings" or "fix lint errors".

Suggestions

Add an explicit trigger clause, e.g. "Use when writing or modifying code, before committing, or when fixing lint, format, or type-check errors."

Include natural trigger variations users would say, such as "lint warnings", "fix lint errors", and "pre-commit checks", alongside the tool names.

Mention the spellcheck skip-list workflow and naming conventions so the capability list reflects what the body actually covers.

DimensionReasoningScore

Specificity

The description lists several concrete areas with named tools — "lint (oxlint), format (oxfmt), type check (tsc), pre-commit hooks, and comment conventions" — going beyond anchor 3's 1-2 actions, but it names domains of standards rather than executable actions and omits coverage areas present in the body (naming conventions, spellcheck handling), so it falls short of anchor 5's comprehensive coverage.

4 / 5

Completeness

The "what" is clear (lint/format/type-check standards with tool names), but there is no "Use when..." clause or equivalent explicit trigger guidance anywhere in the description, which per the judging guidelines caps completeness at 3. It is a solid match for anchor 3 ('clear what, when missing') rather than anchor 4, which requires both.

3 / 5

Trigger Term Quality

"lint", "format", "type check", "pre-commit", and "comment" are natural phrases users would say when needing this skill, matching anchor 4's good coverage. It misses common variations users might actually say — "lint warnings", "fix lint errors", "spellcheck", "ESLint" — keeping it below anchor 5.

4 / 5

Distinctiveness Conflict Risk

The specific tool names ("oxlint", "oxfmt", "tsc") carve out a mostly distinct niche from sibling skills like 1k-sentry or 1k-test-version, fitting anchor 4's "mostly distinct". It retains minor overlap risk with "1k-coding-patterns - General coding patterns", whose general quality/pre-commit guidance could trigger for either skill, so it is not anchor 5.

4 / 5

Total

15

/

20

Passed

Validation

81%

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 13 / 16 Passed

Validation for skill structure

CriteriaDescriptionResult

allowed_tools_field

'allowed-tools' contains unusual tool name(s)

Warning

relative_links

Relative link issues: 2 deeper-than-1-level

Warning

referenced_paths_exist

Referenced path issues: 2 deeper-than-1-level

Warning

Total

13

/

16

Passed

Repository
OneKeyHQ/app-monorepo
Reviewed

Table of Contents

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.