Content
88%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
An exemplary expert-knowledge skill body: token-dense, codebase-specific, and free of padding, with an explicit validation-gated workflow for changes. The main improvement opportunities are a copy-paste example of a taint model entry and moving the deepest design detail into reference files.
Suggestions
Add a minimal example source/sink/sanitizer model entry (showing the hashable spec shape and a 'neutralizes' kind list) so the add-a-model workflow is copy-paste ready.
Consider moving the L4 solver internals, summary-edge table, and prior-art sections into a references/ file, keeping SKILL.md as the leaner overview.
Add one short example of reading an 'explain' finding (intra- vs interprocedural output shape) to ground the debugging use case.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is dense with non-derivable project knowledge (issue numbers like #1983, 0- vs 1-based line-join conventions, cache-key semantics, exact test paths) and assumes Claude's competence — it never explains what taint analysis or CFGs are, and cites Sharir-Pnueli/IFDS as pointers rather than tutorials. Every token earns its place, so it matches the 'lean and efficient' anchor rather than the 'minor over-explanation' anchor. | 5 / 5 |
Actionability | Most guidance is concrete and executable: the validation checklist names exact commands ('node scripts/build.js', 'bench/cfg/measure.mjs --check', targeted vitest directories) and the model-extension section names exact files and test harnesses ('taint/typescript-model.ts', 'test/helpers/ts-cfg-harness.ts'). It falls short of copy-paste-ready because the 'Adding a source / sink / sanitizer' workflow describes the spec shape ('hashable data (no functions)', 'neutralizes lists the EXACT sink kinds') without a minimal example model entry. | 4 / 5 |
Workflow Clarity | The 'Validation checklist for any `--pdg` change' is an explicit five-step sequenced gate list (tsc clean, isolated vitest, golden byte-identical parity, fingerprint check, detect_changes), and the add-a-model workflow is concrete with fixture-assert guidance and per-language harnesses. Checkpoints are explicit and ordered with error-recovery notes ('verify by ISOLATION, not full-suite exit'), matching the anchor-5 example. | 5 / 5 |
Progressive Disclosure | No bundle files exist, and the single SKILL.md is well-organized with clear, self-contained sections. Not 5 because at ~180 lines the deep detail (L4 solver internals, the summary-edge table, prior art, known-FN classes) could be split into reference files to keep the overview lean; not 3 because the inline content is design knowledge, not bulk API reference that clearly belongs elsewhere. | 4 / 5 |
Total | 18 / 20 Passed |