Content
46%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
This skill reads more like a comprehensive ShellCheck reference manual than a concise, actionable skill for Claude. It over-explains fundamentals Claude already knows, inlines extensive reference material that should be in separate files, and lacks a clear guided workflow with validation checkpoints. The concrete code examples are a strength, though some contain errors (identical problem/solution pairs).
Suggestions
Drastically reduce the content to a concise overview (~50-80 lines) covering configuration setup, key integration patterns, and suppression syntax, moving the error code catalog and detailed examples to a separate REFERENCE.md file.
Remove the 'What is ShellCheck?' section and installation instructions — Claude already knows these. Focus only on project-specific configuration decisions and non-obvious patterns.
Fix the broken examples where problem and solution code are identical (SC2086 and SC2206 sections show the same code for both).
Add a clear sequential workflow with validation: e.g., 1) Create .shellcheckrc → 2) Run initial analysis → 3) Review and categorize findings → 4) Fix or suppress with documentation → 5) Verify clean run → 6) Set up CI gate.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Severely verbose for a skill targeting Claude. Explains what ShellCheck is, lists installation methods Claude already knows, describes what POSIX shells are, and includes extensive error code catalogs that belong in a reference file. The 'Best Practices' section is generic advice Claude already knows. Much of this content is reference material that should be in a separate file or omitted entirely. | 2 / 5 |
Actionability | Provides concrete, executable code examples for configuration files, CI/CD integration, pre-commit hooks, and common violation fixes. The examples are mostly copy-paste ready. However, some examples have issues (e.g., the SC2086 'fix' shows the same code as the problem, and the SC2206 example similarly shows identical problem/solution), which slightly undermines actionability. | 4 / 5 |
Workflow Clarity | The CI/CD integration section has a reasonable workflow with failure handling, but there's no overarching workflow for 'setting up ShellCheck for a project' with validation checkpoints. The skill lacks a clear sequential process for analyzing and fixing scripts — it's more of a reference catalog than a guided workflow. No feedback loops for iterative fixing are explicitly defined. | 3 / 5 |
Progressive Disclosure | The content is a monolithic wall of reference material (~300+ lines) that should be split into separate files (error code reference, integration patterns, configuration examples). It references `resources/implementation-playbook.md` but no bundle files exist. The massive inline error code catalog and integration examples would be much better as separate referenced files. | 2 / 5 |
Total | 11 / 20 Passed |