Content
51%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
The body is a richly actionable coding-standards reference with many concrete PASS/FAIL code examples across the TS/JS/React/Node stack, but it is somewhat verbose (re-explaining well-known principles), has no multi-step workflow with validation checkpoints, and inlines everything in one file with no progressive disclosure.
Suggestions
Trim or remove the KISS/DRY/YAGNI/readability principles block and basic naming aphorisms — Claude already knows these; keep only the project-specific conventions.
Move detailed reference material (API design conventions, code-smell catalog, JSDoc guide) into separate files under references/ and link to them from SKILL.md to enable progressive disclosure.
Add a short applied workflow with validation checkpoints (e.g., 'lint → type-check → review against these standards → fix → re-verify') so the standards can be executed as a process, not just browsed.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is mostly concrete PASS/FAIL code examples that earn their tokens, but it includes unnecessary explanation of concepts Claude already knows — the KISS/DRY/YAGNI/readability principles block and aphorisms like '代码被阅读的次数远多于被编写的次数' — and the PASS/FAIL doubling on basic naming examples could be tightened. It is not severely padded (score 2) because the bulk is actionable code, but it carries more than minor over-explanation. | 3 / 5 |
Actionability | It provides extensive concrete, executable TypeScript/React snippets covering naming, error handling, async, types, components, hooks, API design, validation, memoization, and testing — mostly copy-paste ready. Minor gaps (placeholder '// Implementation' bodies in getMarket/searchMarkets and empty '() => { }' test bodies) keep it just below fully executable at score 5. | 4 / 5 |
Workflow Clarity | This is a reference/standards document, not a sequenced process: sections are roughly ordered (principles → language → React → API → file org → comments → perf → testing → smells) but there are no defined operational steps or validation checkpoints for applying the standards, and validation is absent. It is above score 1 (content is coherent and has an activation list) but lacks the sequenced steps required for score 3. | 2 / 5 |
Progressive Disclosure | The body is well-organized into a clear hierarchy of headers, but everything is inlined in a single ~530-line SKILL.md with no external references or bundle files — content that could be split out (detailed API design, code-smell catalog, JSDoc guide) lives inline. It is better than 'minimal structure' (score 2) due to the clear headers, but has no signaled one-level-deep references required for score 4. | 3 / 5 |
Total | 12 / 20 Passed |