new-monitoring-feature

Add a new monitoring target / layer to SkyWalking OAP. Orients you to the OAL / MAL / LAL / SpanListener / SegmentListener extension points, the UI template + submodule touchpoints, the docs set that must move together, and the cross-cutting traps that don't live in any one skill.

1.10x

Quality

78%

Does it follow best practices?

Impact

88%

1.10x

Average score across 3 eval scenarios

Securityby

Passed

No findings from the security scan

Fix and improve this skill with Tessl

tessl review fix ./.claude/skills/new-monitoring-feature/SKILL.md

Quality

Content

77%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

An exceptionally actionable, well-sequenced wiring map: exact paths, commands, code, and validation posture with a clear 0–10 workflow. It is held back by duplication between the traps table and the section bodies, and by inlining reference-catalog material that belongs in separate bundle files.

Suggestions

Deduplicate the §9 traps table: entries already covered in §2–§7 (histogram bucket-unit 1000x, LAL layer:auto metadata, config-dump drift, SW_UI_TEMPLATE_FORCE_RELOAD, setup-curl retry) appear nearly verbatim twice — keep one canonical location and cross-reference it.

Move the §9 cross-cutting traps table and/or the §10 reference-extensions catalog into a references/ file, keeping SKILL.md as the lean index it claims to be ('This one is the wiring map').

Fix the stray paragraph at line 320 ('E2E-side authoring traps...') that splits the §9 markdown table into two tables, the second of which loses its header row.

Dimension	Reasoning	Score
Conciseness	Per-line it is dense and repo-specific with no explaining of concepts Claude already knows, but the ~400-line body repeats itself noticeably: the §9 traps table restates §2 (CommonAnalysisListener anti-pattern), §3.3 (histogram le scale, overflow bucket), §4 (layer:auto gotcha), §5.2 (force-reload), and §7.3 (curl retry pattern) almost verbatim. That is more than the 'minor instances' of the 4 anchor and far from the padding of the 1–2 anchors.	3 / 5
Actionability	Fully concrete throughout: executable commands ('./mvnw clean flatten:flatten install javadoc:javadoc -B -q -Pall -Dmaven.test.skip -Dcheckstyle.skip -Dgpg.skip', 'curl -sS -f --retry 30 --retry-delay 5 --retry-connrefused --retry-all-errors --max-time 10 ...' + 'set -e', 'SW_UI_TEMPLATE_FORCE_RELOAD=true'), copy-ready Java/YAML snippets (Layer.register examples, SampleFamilyBuilder ... .defaultHistogramBucketUnit(TimeUnit.MILLISECONDS)), and exact file paths for every touchpoint.	5 / 5
Workflow Clarity	Sections 0–10 form an explicit sequence (register Layer → pick extension point → trace/metrics/logs → UI → docs → e2e → ordered pre-submit checklist) with validation checkpoints throughout ('Verify every new feature locally before pushing to CI', 'fire every verify step with swctl by hand at least once', the ordered §8 checklist). Feedback loops are explicit and concrete, so no cap applies.	5 / 5
Progressive Disclosure	No bundle files exist (references/, scripts/, assets/ are all absent), so the 38KB body carries everything inline. Links to repo docs and sibling skills (run-e2e, compile, license, package) are clearly signaled and one level deep, but content that clearly belongs in separate files — the ~35-row §9 traps table and the §10 reference-extensions catalog — is inlined, matching the 3 anchor. A stray paragraph at line 320 also splits the §9 markdown table mid-body, breaking navigation.	3 / 5
	Total	16 / 20 Passed

Description

78%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

A strong, highly specific description that names the domain, its extension points, and the concrete surfaces it covers. Its main gaps are the absent explicit 'Use when...' trigger clause and second-person phrasing ('Orients you'), which costs it specificity under the rubric.

Dimension	Reasoning	Score
Specificity	Enumerates multiple concrete capabilities ('OAL / MAL / LAL / SpanListener / SegmentListener extension points', 'UI template + submodule touchpoints', 'docs set that must move together'), matching the 5 anchor — but 'Orients you to...' is second-person voice, and the rubric mandates a 1-point specificity penalty for second person.	4 / 5
Completeness	The 'what' is explicit and enumerated, and the opening imperative 'Add a new monitoring target / layer to SkyWalking OAP' conveys the triggering task, but there is no explicit 'Use when...' clause, so it does not reach the 5 anchor while clearly exceeding the 3 anchor's 'when only weakly implied'.	4 / 5
Trigger Term Quality	Good natural keyword coverage ('monitoring target / layer', 'SkyWalking OAP', 'extension points', 'UI template', 'docs'), which a contributor would plausibly say verbatim; a few natural variations (receiver, instrumentation, agent) are missing, so it sits just below the comprehensive 5 anchor.	4 / 5
Distinctiveness Conflict Risk	Proper nouns like 'SkyWalking OAP', 'OAL / MAL / LAL', and 'SpanListener / SegmentListener' carve out a clear niche with distinct triggers and minimal overlap risk with any other skill.	5 / 5
	Total	17 / 20 Passed

Validation

93%

Warnings & errors only

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 15 / 16 Passed

Validation for skill structure

Criteria	Description	Result
relative_links	Relative link issues: 19 suspicious	Warning

	Total	15 / 16 Passed

Repository: apache/skywalking
Path: .claude/skills/new-monitoring-feature/SKILL.md
Commit: 0a01d89

Reviewed: 5 days ago

Table of Contents

Discovery Implementation Validation

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.