Add a new monitoring target / layer to SkyWalking OAP. Orients you to the OAL / MAL / LAL / SpanListener / SegmentListener extension points, the UI template + submodule touchpoints, the docs set that must move together, and the cross-cutting traps that don't live in any one skill.
82
76%
Does it follow best practices?
Impact
88%
1.10xAverage score across 3 eval scenarios
Passed
No known issues
Optimize this skill with Tessl
npx tessl skill review --optimize ./.claude/skills/new-monitoring-feature/SKILL.mdQuality
Discovery
67%Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.
The description is strong in specificity and distinctiveness, clearly naming the technology (SkyWalking OAP) and the concrete extension points involved. Its main weaknesses are the lack of an explicit 'Use when...' clause and the reliance on highly technical jargon that users may not naturally use when requesting help. The second-person 'Orients you' phrasing also violates the third-person voice guideline.
Suggestions
Add an explicit 'Use when...' clause, e.g., 'Use when adding a new monitoring target, data source, or observability layer to SkyWalking OAP.'
Include more natural trigger terms users might say, such as 'add metrics', 'new data source', 'extend SkyWalking', 'custom monitoring', or 'observability plugin'.
Change 'Orients you to' to third-person voice, e.g., 'Guides through' or 'Covers the OAL/MAL/LAL extension points...'
| Dimension | Reasoning | Score |
|---|---|---|
Specificity | Lists multiple specific concrete actions and extension points: OAL/MAL/LAL/SpanListener/SegmentListener extension points, UI template + submodule touchpoints, docs set coordination, and cross-cutting traps. These are concrete, actionable elements rather than vague language. | 3 / 3 |
Completeness | The 'what' is well covered (add monitoring target, orient to extension points, UI templates, docs, cross-cutting traps). However, there is no explicit 'Use when...' clause or equivalent trigger guidance — the 'when' is only implied by the opening phrase 'Add a new monitoring target.' This caps completeness at 2 per the rubric guidelines. | 2 / 3 |
Trigger Term Quality | Includes domain-specific terms like 'SkyWalking OAP', 'monitoring target', 'OAL', 'MAL', 'LAL', 'SpanListener', 'SegmentListener', 'UI template' which are relevant but highly technical. Missing more natural user phrases like 'add metrics', 'new data source', 'extend observability'. Users might not say 'monitoring target / layer' naturally. | 2 / 3 |
Distinctiveness Conflict Risk | Highly distinctive with a very clear niche: SkyWalking OAP monitoring target addition. The specific technology (SkyWalking) and the specific task (adding a monitoring layer) combined with the named extension points make it extremely unlikely to conflict with other skills. | 3 / 3 |
Total | 10 / 12 Passed |
Implementation
85%Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
This is a high-quality, deeply actionable skill that serves as a comprehensive wiring map for adding new monitoring layers to SkyWalking OAP. Its greatest strengths are the precise, executable guidance (exact file paths, SPI interfaces, registration mechanisms, code snippets) and the extensive trap table drawn from real-world experience. Its main weakness is length and some redundancy — the same warnings (client-side layers don't need trace analysis, histogram pitfalls, config-dump drift) appear in multiple sections, inflating token cost without proportional value.
Suggestions
Deduplicate the trap table (§9) by removing entries that are already covered in detail in earlier sections (e.g., histogram pitfalls from §3.3, client-side trace analysis anti-pattern from §2, config-dump from §3.2/§7) and replacing them with back-references like 'See §3.3'.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The skill is extremely long (~500+ lines) and while most content is genuinely useful domain-specific knowledge Claude wouldn't have, there is significant repetition — the histogram pitfalls appear in both §3.3 and the §9 trap table, the 'don't extend trace analysis for client-side layers' warning appears in §2 header, §3.1, and §9. The trap table in §9 is massive and partially duplicates earlier sections. Some tightening would preserve all the value at lower token cost. | 2 / 3 |
Actionability | Exceptionally actionable — provides exact file paths, concrete Java code snippets, specific YAML configuration keys, precise CLI commands, exact naming conventions (folder naming with underscores not hyphens), specific environment variables, and detailed registration steps. The extension point table in §1 maps signals to exact SPI interfaces and registration paths. The trap table gives specific symptoms and fixes. | 3 / 3 |
Workflow Clarity | The skill provides a clear end-to-end workflow from §0 (register Layer) through §8 (pre-submit checklist) with explicit sequencing. §8 is an ordered checklist with links to dedicated skills for each step. Validation checkpoints are explicit throughout — 'verify locally before pushing to CI', 'run the new e2e case end-to-end locally', 'fire every verify step with swctl by hand'. The working posture section establishes scope boundaries and stop-and-confirm gates. | 3 / 3 |
Progressive Disclosure | Excellent progressive disclosure structure — the skill explicitly positions itself as 'the wiring map' and 'index' that points to dedicated skills for each concern (compile, license, package, run-e2e, gh-pull-request). References to concept docs (OAL, MAL, LAL), CLAUDE.md files for compiler internals, and SWIP design docs are all one level deep with clear signaling. Section headers provide scannable navigation. | 3 / 3 |
Total | 11 / 12 Passed |
Validation
100%Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.
Validation — 11 / 11 Passed
Validation for skill structure
No warnings or errors.
bf0fe4b
Table of Contents
If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.