Content
88%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A tightly written, well-structured command workflow with strong sequencing, explicit user-approval gates, and a well-bounded automatic fix loop including its own stop conditions. The main weaknesses are minor: the staged-reviewer subagent prompt is only implied, and the referenced `scripts/git-unstaged-diff.sh` is not present in the bundle and is not qualified as belonging to another skill.
Suggestions
Specify what to tell the staged-reviewer subagent beyond the repository root (e.g., a minimal prompt template or a note that the subagent definition already contains its instructions), so step 3 is fully executable without inference.
Qualify the `scripts/git-unstaged-diff.sh` reference with the skill or repository it lives in (or ship it in this skill's `scripts/` directory), since no `scripts/` directory exists in the bundle and the bare path leaves Claude to guess its provenance.
Consider having the automatic fix loop reference the step 5 partial-staging procedure ("apply the same snapshot/Method A procedure as step 5") instead of restating it, to remove the one duplicated block of instructions.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is lean and assumes Claude's competence: no git or subagent concepts are explained, and every line is an instruction, a condition, or a one-sentence rationale for a rule ("You wrote them; a self-review defeats the purpose of this skill"). The partial-staging rules reappearing in the auto-fix section are a compressed restatement that keeps the alternative mode self-contained, not padding, so it fits the 'lean and efficient; every token earns its place' anchor rather than level 4's 'minor instances that could be trimmed'. | 5 / 5 |
Actionability | Guidance is largely executable: named tools and paths (`scripts/git-unstaged-diff.sh <repo-root>`, `claude-subagents/staged-reviewer.md`, `~/.claude/agents/`), concrete commands (`git add <file>`), a precise footer format, and clear stop conditions. It falls short of fully copy-paste-ready because the prompt to give the `staged-reviewer` subagent is only implied by "Give it the repository root", and the referenced `scripts/git-unstaged-diff.sh` does not exist in this skill's bundle with no skill-qualification on the path — matching level 4's 'concrete commands with minor gaps' rather than level 5's 'specific examples cover the common cases'. | 4 / 5 |
Workflow Clarity | The 7-step workflow is clearly sequenced with explicit validation checkpoints throughout: a guard check before anything else, "Wait for the user" decision points, re-collection of staged changes when state has drifted, a fix-report-re-review feedback loop continuing the same reviewer, and an alternative auto-fix mode with explicit stop conditions (verdict OK, needs human decision, or 3 rounds). This matches the top anchor's 'explicit validation steps; feedback loops for error recovery' — the commit is gated on explicit user approval, so the destructive-operation cap does not apply. | 5 / 5 |
Progressive Disclosure | Sections are well organized (Arguments, Guard, Workflow, Automatic fix loop) and external material is delegated one level deep with clearly signaled paths (`git-workflows`' `references/op_commit_message.md` and `references/partial_staging.md`). It stops short of level 5 because `scripts/git-unstaged-diff.sh` is referenced unqualified but absent from the skill's bundle (no `scripts/` directory), leaving its provenance ambiguous — a minor organization gap matching level 4 rather than level 3, since references are clearly signaled and no content that belongs in a separate file is inlined. | 4 / 5 |
Total | 18 / 20 Passed |