Content
85%Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A highly actionable, well-structured skill body with excellent workflow guidance and progressive disclosure; its only real weakness is duplication between the invariants, dry-run, and 'internalize' sections that inflates length without adding new information.
Suggestions
Collapse the 'Invariants (do not break)' and 'Always run dry-run first when rewriting' sections into the earlier 'Three things the agent must internalize' section — they restate the two-pass write trick and dry-run-before-apply rule verbatim.
The body references install.sh (POSIX) and install.ps1 (Windows) as shipped scripts, but neither file is present in the bundle; either add them or point to references/install.md as the canonical install path to avoid a dead reference.
The two debug sections ('When sg returns 0 matches' and the validate subcommand examples) overlap on regex-misuse detection; merge the validate-first guidance into one place.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is mostly tight and assumes Claude's competence (no 'what is an AST' padding), but the 'Invariants (do not break)' and 'Always run dry-run first when rewriting' sections restate the two-pass write trick and dry-run-before-apply guidance already covered in 'Three things the agent must internalize'. Not level 3 because this duplication is removable padding; not level 1 because it never bloats into explaining concepts Claude already knows. | 2 / 3 |
Actionability | Dense with executable, copy-paste-ready commands — 'python3 scripts/ast_grep_helper.py search ...', 'sg run -p ... --json=compact', real subcommands (search/replace/scan/validate/doctor), and real flags. Not level 2 because the guidance is complete and runnable, not pseudocode or abstract. | 3 / 3 |
Workflow Clarity | Multi-step processes are sequenced with explicit validation checkpoints: the numbered 5-step dry-run flow ('Search → dry-run → inspect → refine → apply'), the prioritized '0 matches' debug workflow, and the validate→fix→retry feedback loop for batch rewrites. Not level 2 because validation checkpoints and error-recovery loops are explicit rather than implicit. | 3 / 3 |
Progressive Disclosure | A clear overview with a 'Required reading (in order of priority)' section that signals seven real one-level-deep reference files (patterns.md, pitfalls.md, recipes.md, cli.md, yaml-rules.md, sgconfig.md, install.md), each annotated with when to read it. Not level 2 because references are well-signaled and appropriately split rather than inlined. | 3 / 3 |
Total | 11 / 12 Passed |