Content
75%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A highly actionable, well-structured migration workflow with real call sites, a decision table, and exact test commands. Its weaknesses are redundancy (the wrap-don't-wrap rule is repeated four times) and a workflow whose validation step lacks an explicit failure-recovery loop.
Suggestions
Consolidate the anti-wrapper guidance into one section plus the Checklist — it currently appears in four places (the 'Do not' paragraph, 'Do not wrap styled HIG controls' with its table, 'Anti-patterns', and 'Checklist').
Add a short failure-recovery step after the test step, e.g. 'If ComponentStyleTests fail, fix token wiring in the pure mapping functions and re-run yarn nx run cds-ios:test'.
Move the per-pattern rationale (e.g. why a CDSButton swallows ButtonRole/toolbar placement) into the referenced 'CDS SwiftUI Best Practices' Linear doc and keep only the decision table and call sites inline.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is dense and project-specific (no textbook SwiftUI explanations), but the anti-wrapper rule is stated four times (the "Do not" paragraph, the "Do not wrap styled HIG controls" section with its table, the Anti-patterns list, and the Checklist), and includes rhetorical padding like "that is 'the app is CDS', that is 'the app is covered in CTAs'". It could be meaningfully tightened, matching the 3 anchor; it is not a 4 because the duplication is more than minor trimming. | 3 / 5 |
Actionability | Fully concrete guidance throughout: copy-ready Swift call sites (`.buttonStyle(.cds(.primary))`, `Text("Balance").cdsText(.title3)`), exact file paths (`packages/cds-ios/Sources/Components/<Name>.swift`, `Tests/CDSDesignSystemTests/ComponentStyleTests.swift`), and exact commands (`yarn nx run cds-ios:test`). The five-row pattern decision table makes classification mechanical. Matches the 5 anchor for executable, copy-paste-ready coverage. | 5 / 5 |
Workflow Clarity | There is a coherent sequence (read AGENTS.md and Linear refs → classify the pattern → implement steps 1-8 → test/build) closed by a checklist, and a validation step exists ("yarn nx run cds-ios:test"). It is not a 5 because the end-to-end flow must be assembled from separate sections and there is no error-recovery loop (what to do when the test or token-lock fails), and not a 3 because checkpoints and the checklist are explicit. | 4 / 5 |
Progressive Disclosure | No bundle files exist, so all content lives in SKILL.md with clear section headers, and every external pointer is clearly signaled and one level deep (Linear docs, `packages/cds-ios/AGENTS.md`, `packages/mobile/` sources). Good structure with minor gaps — e.g. the pattern-decision rationale could live in the referenced Linear doc — which matches the 4 anchor; a 5 would require the long-term reference material (RN→iOS map details) to be explicitly split out rather than deferred to external Linear docs. | 4 / 5 |
Total | 16 / 20 Passed |