Content
86%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A lean, high-density review checklist that captures genuinely non-obvious EF Core query-pipeline constraints and verification tools. Its weaknesses are modest: some directives lack concrete examples, and the thematic sections are not framed as an ordered review sequence.
Suggestions
Add one compact example of the expected specification-test pattern (shared virtual test with a provider override that calls the base and adds an AssertSql baseline) to make the Regression Test Ownership guidance concrete and imitable.
For the equivalence bullet in Optimizations, show a minimal concrete pair of expressions that are semantically equivalent but not blindly expression-equal, to anchor the directive.
Add a short ordered review workflow (place/verify regression coverage, check translation fallback state, verify optimization equivalence, validate generated SQL via AssertSql) so the section order reads as a sequence with explicit checkpoints.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Every bullet encodes non-obvious project constraints ('theory rows are not inherently parallel, and reset in `finally` is not mutual exclusion'; 'SQL UNKNOWN can be filtered like `false` in a predicate but not in a projected value') with zero padding and no explanation of concepts Claude already knows. | 5 / 5 |
Actionability | Guidance names exact types and methods to check (`SplitQueryResultCoordinator`, `SplitQueryingEnumerable`, `GroupBySplitQueryingEnumerable`, `ToQueryString()`, `ExpressionPrinter`, `AssertSql()`), but several optimization bullets are principle-level directives ('Match the equivalence needed by the rewrite, not blindly by expression equality') without a concrete example of how to apply them. | 4 / 5 |
Workflow Clarity | Sections organize review concerns with embedded validation directives and a dedicated Validation section listing verification tools, but there is no explicit end-to-end sequence or validate-fix-retry feedback loop tying the sections into an ordered workflow. | 4 / 5 |
Progressive Disclosure | The body is under 50 lines, self-contained, and organized into clear topical sections (Regression Test Ownership, Translation, Optimizations, Split Queries, Validation) with no external references needed — and none are used. | 5 / 5 |
Total | 18 / 20 Passed |