Content
86%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A lean, expert-level review checklist that assumes competence and concentrates entirely on non-obvious EF Core query-pipeline knowledge, with concrete class and tool names throughout. It falls just short of top marks on actionability and workflow clarity only because the spec-test/override pattern is described but not exemplified, and the material is organized by topic rather than as a sequenced workflow.
Suggestions
Add one minimal inline example of the shared virtual specification test plus a provider override calling the base, since the regression-test ownership rules repeatedly reference that structure without showing it.
Add a short entry-point line indicating the order of application (e.g., locate the change → apply the matching section's checks → run the Validation section's tools) so the topical checklists function as a sequence.
In Validation, show the exact AssertSql()/precompiled-query usage shape (one short snippet) so the verification steps are copy-paste ready rather than named only.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Every bullet delivers project-specific knowledge (EF Core internals, test ownership rules, null-semantics compensation) with zero padding and no explanation of concepts Claude already knows — e.g., "SQL UNKNOWN can be filtered like `false` in a predicate but not in a projected value or under negation" is pure non-obvious domain detail. Not 4 because there are no over-explained passages that could be trimmed. | 5 / 5 |
Actionability | Concrete APIs and verification tools are named throughout ("`SplitQueryResultCoordinator`", "`PrecompiledQueryTestHelpers` verifies generation, compilation, and execution", "`ToQueryString()` shows generated SQL without executing"), giving mostly executable guidance. Not 5 because patterns the body governs — the shared virtual spec test and provider override structure — are described but never shown with even a minimal example, leaving a minor gap for instruction-only guidance. | 4 / 5 |
Workflow Clarity | Validation checkpoints are explicit and pervasive ("cover both eligible and rejected shapes with exact result assertions in sync and async", "Test that successful move separately from the subsequent terminal call", "Prove cross-command consistency with a writer transaction and an explicit barrier between reads"), and sections map to the pipeline areas a change touches. Not 5 because the body is a set of topical checklists rather than a sequenced process, so the order in which to apply the sections is implicit. | 4 / 5 |
Progressive Disclosure | The body is under 50 lines, references no external files, and no bundle files exist, so all content is appropriately inline under five well-labeled sections (Regression Test Ownership, Translation, Optimizations, Split Queries, Validation). Per the simple-skill guideline, well-organized sections alone earn the top anchor here. | 5 / 5 |
Total | 18 / 20 Passed |