Content
75%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A well-structured, actionable workflow body with concrete build/test commands, clear scoping checklists, and a defined output format. It falls short of top marks mainly because the central test-authoring conventions are delegated to an external file with no in-bundle reference or fallback example, and no error-recovery guidance accompanies the verification steps.
Suggestions
Inline one minimal, complete test example (a MauiXXXXX.xaml.cs using [Values] XamlInflator and MockCompiler) so the skill remains actionable even if the external instructions file is unavailable, or add the conventions file to a references/ bundle with a clearly signaled link.
Add a short error-recovery step after the build/run commands (e.g., 'If the build fails, re-check naming and namespace conventions from Step 1 and rebuild') to close the feedback loop in the workflow.
Remove the opening sentence that duplicates the frontmatter description, and trim the Step 1 bullet list to only what is needed to decide whether to open the instructions file.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is lean and assumes competence (checklists, commands, output template), but the opening sentence repeats the frontmatter description and Step 1's conventions bullet list partially duplicates the referenced instructions file. Not 5 due to this redundancy; not 3 since there is no concept re-teaching or padding. | 4 / 5 |
Actionability | Concrete, executable commands with full paths ("dotnet build src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj -c Debug --no-restore -v q", "dotnet test ... --filter \"FullyQualifiedName~MauiXXXXX\"") are provided, but the core test-authoring patterns ("[Values] XamlInflator", "MockCompiler", "MockSourceGenerator") are only named and delegated to an external repo file rather than shown. Not 5 because of this gap; not 3 since what is given is executable rather than pseudocode. | 4 / 5 |
Workflow Clarity | A clear four-step sequence (read guidelines → create files → build and run → verify behavior) with explicit build/run checkpoints and expected pass/fail semantics in Step 4. Not 5 because there is no error-recovery loop (e.g., what to do when the build or test run fails); not 3 since validation checkpoints are explicit rather than missing. This is not a destructive or batch operation, so the workflow cap does not apply. | 4 / 5 |
Progressive Disclosure | Well-sectioned ~80-line body with a clearly labeled References section pointing one level deep (".github/instructions/xaml-unittests.instructions.md", test project, existing issues). Not 5 because the skill exceeds 50 lines and its key detail lives in a repo-relative file outside the skill bundle (no references/, scripts/, or assets/ bundle files exist); not 3 since references are clearly signaled and content is well organized. | 4 / 5 |
Total | 16 / 20 Passed |