Content
75%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A well-structured, lean overview with a clear decision step, sequenced lifecycle steps, concrete file targets, and appropriate deferral of detail to wiki references. The main gaps are the absent inline code example for conditioning a feature, no error-recovery guidance, and slightly repetitive external links.
Suggestions
Inline a minimal C# example of the AreFeaturesEnabled check (or the wave version lookup) so the core conditioning pattern is executable without opening ChangeWaves-Dev.md.
Add brief recovery guidance for the failure points, e.g., what to do when the wave version in Versions.props does not match any wave in ChangeWaves.cs, or when the wiki heading for the wave version already exists with a conflicting format.
Reference each wiki document once and reuse short textual mentions afterward, reducing the repeated ChangeWaves-Dev.md/ChangeWaves.md links.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is efficient and shares only project-specific knowledge Claude cannot know (the MSBUILDDISABLEFEATURESFROMVERSION mechanism, wave rotation policy, good/bad candidate criteria). It is not a 5 because the 'Decide Whether a Change Wave Is Appropriate' section partially duplicates the boundary already delegated to the assessing-breaking-changes skill, and a few sentences could be tightened. | 4 / 5 |
Actionability | Concrete guidance includes exact file paths (src/Framework/ChangeWaves.cs, eng/Versions.props, documentation/wiki/ChangeWaves.md), a copy-paste markdown entry example, and the named API (AreFeaturesEnabled). It falls short of 5 because the core code pattern for conditioning a feature is entirely deferred to ChangeWaves-Dev.md with no inline example. | 4 / 5 |
Workflow Clarity | A clear sequence (decide, then Steps 1–4) with checkpoints: the opt-out test in Step 3 verifies old behavior is preserved, and a closing checklist validates completion; the destructive retire step is explicitly gated on request. It is not 5 because there is no error-recovery/feedback loop (e.g., what to do if the wave version lookup or wiki heading conflicts). | 4 / 5 |
Progressive Disclosure | Detail is appropriately split into one-level-deep, clearly signaled references (developer-facing ChangeWaves-Dev.md vs public-facing ChangeWaves.md), keeping SKILL.md an overview. It is not 5 because the same wiki links are repeated three and two times respectively and the references live outside the skill bundle, adding minor navigation noise. | 4 / 5 |
Total | 16 / 20 Passed |