Content
82%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
An exemplary dense, repo-specific skill body: fully actionable rules, concrete code and commands, and a strong source-build validation loop with named failure diagnostics. The only deductions are minor — slight cross-reference repetition, no unified ordered migration procedure, and a monolithic length that could benefit from splitting catalogs into a reference file.
Suggestions
Deduplicate the cswin32-com parity-table link (Rules §6 and the ThrowOnFailure bullet both cite it) and the ComTypes.FILETIME vs Win32.Foundation.FILETIME note (stated in both FILETIME Conversions and Type Conversions) — cite each once and cross-reference the section.
Add a short numbered end-to-end migration checklist (inspect original DllImport semantics → replace with PInvoke.* → apply dual guard → map constants → run both builds) at the top to unify Rules, Blittable signatures, and Source-Build Verification into one sequence.
Consider moving the Constant Replacements catalog and Gotchas details into a references/ file, keeping SKILL.md as a leaner overview with well-signaled one-level-deep links.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Dense and expert-level throughout — no padding, no explanation of concepts Claude already knows; every rule carries repo-specific information. Falls short of 5 due to minor redundancy: the cswin32-com parity-table link is repeated within ~15 lines (Rules §6 and the Blittable signatures section), and the ComTypes.FILETIME vs Win32.Foundation.FILETIME distinction is stated in both the FILETIME Conversions section and Type Conversions. | 4 / 5 |
Actionability | Fully executable guidance: copy-paste-ready shell commands for both normal and source builds, concrete C# for the dual-guard and BufferScope patterns, exact constant mappings (NativeMethodsShared.S_OK → HRESULT.S_OK), exact file paths (src/Framework/NativeMethods.txt, Directory.BeforeCommon.targets), a guard-selection table, and named diagnostic codes. The common cases are covered with specifics. | 5 / 5 |
Workflow Clarity | Rules 1–6 form a coherent migration sequence, and the Source-Build Verification section is an explicit REQUIRED validation checkpoint with a feedback catalog mapping failure codes (IDE0005, IDE0051/52, CA1823, CS1587) to fixes. Not a 5 because no single ordered end-to-end migration procedure ties the rules, error-parity checks, and verification builds into one checklist — the sequence must be assembled from separate sections. | 4 / 5 |
Progressive Disclosure | Well-sectioned single file with clearly signaled, one-level-deep references (paired-skill anchors like #error-handling-parity-when-migrating and repo source paths such as CorOpenFlags.cs); no bundle files exist to verify beyond these. Not a 5 because at ~185 lines, self-contained catalogs (Constant Replacements, Gotchas) could reasonably be split into a reference file to keep SKILL.md a leaner overview. | 4 / 5 |
Total | 17 / 20 Passed |