Content
67%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
This is a strong, deeply project-specific skill body: it encodes hard-won operational knowledge (dependency ordering, whack-a-mole prevention, escalation cutoffs) with executable commands and explicit validation checkpoints. Its main weaknesses are repetition of the remote-clean and precommit-generate guidance across sections, a platform-specific paste command, and no pre-flight check before the destructive workspace clean.
Suggestions
Consolidate the repeated remote-workspace cleaning and precommit-generate escalation guidance into one authoritative section and reference it from the others to cut duplication.
Add a Linux alternative for clipboard paste (e.g. wl-paste/xclip) or generalize the "git apply" instruction to "paste the diff from CI".
Insert a validation checkpoint before the destructive "git reset --hard HEAD && git clean -fdx" (confirm no uncommitted work or stash first) in both places it appears.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is dense with non-obvious, project-specific knowledge (dependency graph, escalation protocol, Apple-scaffold contract), but key guidance is repeated in multiple sections — remote-workspace cleaning appears in the top notes, triage step 3, and "Can't Reproduce Locally", while the precommit-generate escalation appears in Whack-a-Mole, the Escalation Protocol, and Generate-caused Failures. Not 4 because the repetition is noticeable enough that the document could be tightened by consolidating these. | 3 / 5 |
Actionability | Commands are concrete and copy-paste ready ("gh run rerun --failed", "./frb_internal lint --fix", "git reset --hard HEAD && git clean -fdx", "./frb_internal precommit-generate") and cover the common failure classes. Not 5 because "pbpaste | git apply" is macOS-only with no Linux alternative given, and a few fixes are policy statements without an executable step. | 4 / 5 |
Workflow Clarity | The 5-step Triage Order and the 7-step Escalation Protocol are clearly sequenced with explicit validation checkpoints ("If it passes on retry -> flaky", "Only accept regenerated outputs after the source node is stable", "verify generated output is present"). Not 5 because the destructive "git reset --hard HEAD && git clean -fdx" step lacks a pre-validation checkpoint (e.g. confirming no needed uncommitted work) before discarding state. | 4 / 5 |
Progressive Disclosure | The body is well-structured (triage order, quick-reference table, dependency graph, per-failure-type fixes, common mistakes, related skills) with clear cross-skill pointers (frb-dev-env, frb-fix-merge-conflict, frb-ci-filter). Not 5 because at ~320 lines the advanced material (mermaid dependency graph, escalation protocol) is inlined rather than split into reference files, and no bundle structure exists to offload it. | 4 / 5 |
Total | 15 / 20 Passed |