Content
92%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A well-engineered skill body: a routed multi-step workflow with validation checkpoints, concrete executable guidance (imports, commands, path conventions, decorator mappings), and clean progressive disclosure into four real reference files. The only weakness is mild redundancy — the critical constraints are repeated across the blockquotes, inline comments, and final checklist.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is dense, imperative, and assumes Claude's competence (no padding explaining pytest, Django, or ORM basics), with domain-specific knowledge (silo decorators, mirror paths, outbox patterns) earning its tokens. However, the factory/silo-mode rules are stated three times (Critical Constraints blockquotes, inline comments like 'Use ONLY for direct ORM queries — never for factory calls', and the Step 7 checklist) and the decorator tables partially duplicate the quick-reference sections — minor trimming opportunities matching the score-4 anchor. | 4 / 5 |
Actionability | Fully executable guidance throughout: exact mirror-path mappings (src/sentry/foo/bar.py → tests/sentry/foo/test_bar.py), a concrete run command ('pytest -svv --reuse-db tests/sentry/path/to/test_file.py'), copy-paste import blocks, and scenario-to-decorator/base-class tables for every test category. Matches the score-5 anchor (copy-paste ready, covers common cases). | 5 / 5 |
Workflow Clarity | Steps 1-7 are clearly sequenced with a signal-to-category routing table, explicit ambiguity handling ('If the signal is ambiguous, ask the user to clarify'), context-gathering steps, and an explicit Step 7 validation checklist with nine checkpoints before presenting the test. Matches the score-5 anchor (clear sequence, explicit validation, checklist for complex processes). | 5 / 5 |
Progressive Disclosure | The body stays an overview and each of the four category steps clearly signals a one-level-deep reference ('Load references/rpc-service-tests.md for complete templates and patterns'); all four referenced files exist on disk, and the inline quick-reference tables are appropriately sized for the always-loaded body. Matches the score-5 anchor (clear overview, well-signaled one-level-deep references). | 5 / 5 |
Total | 19 / 20 Passed |