Content
92%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
An exemplary skill body for a complex multi-operation system: a routing table dispatches to numbered steps, each carrying executable code, and validation is built in via test code and a pre-flight checklist. Progressive disclosure is well executed with four real, one-level-deep reference files. The only notable imperfection is minor redundancy around repeated pointers to types.py and some glossary/step overlap.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is dense and assumes Claude's competence (no explanation of dataclasses, enums, or what notifications are), with every code snippet earning its place. It falls short of lean-perfect due to minor redundancy, e.g. Step 2 points to types.py twice ("For examples, load src/sentry/notifications/platform/types.py" and again "All NotificationCategory options are defined in the src/sentry/notifications/platform/types.py file"), and the glossary table partially overlaps the Step descriptions. This is the level-4 anchor: efficient with minor instances that could be trimmed, not the padded verbosity of level 3. | 4 / 5 |
Actionability | Every step ships executable, copy-paste-ready code with clearly-marked placeholders: the enum addition, NOTIFICATION_SOURCE_MAP registration, frozen dataclass, @template_registry.register template with full render(), the sending pattern guarded by has_access(), and complete template/service/renderer test classes including the exact pytest command "pytest -svv --reuse-db tests/sentry/notifications/platform/". The coverage matches the common cases (adding a notification end-to-end). Not a 4: there are no gaps — even file placement ("templates/<your_notification>.py", "{provider}/renderers/{name}.py") and the required __init__.py import are specified. | 5 / 5 |
Workflow Clarity | A routing table ("I want to... | Go to Steps 2-5 / Step 6 / Step 7") routes each operation, steps are numbered 1-9, Step 8 provides concrete test code, and Step 9 is an explicit pre-flight checklist with verification commands ("example_data produces valid output via render_example()", "Tests pass: pytest -svv --reuse-db ...", "Pre-commit passes"). This matches the level-5 anchor: clear sequence with explicit validation steps and a checklist for a complex process. Not a 4: validation checkpoints are explicit and command-backed rather than minor-gapped. | 5 / 5 |
Progressive Disclosure | SKILL.md is a true overview: each step keeps only the essential inline content and signals deeper material with clearly-marked one-level-deep pointers — "load references/data-and-templates.md" (Steps 3 and 4), "references/targets-and-sending.md" (Step 5), "references/custom-renderers.md" (Step 6), "references/provider-template.md" (Step 7) — and all four referenced files actually exist in references/. Bulk detail (full provider scaffold, Seer renderer example) is correctly deferred to those files. Not a 4: there are no organization gaps; navigation is trivial via the routing table and step headers. | 5 / 5 |
Total | 19 / 20 Passed |