Content
71%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
The body is lean, well-sequenced, and actionable with concrete LLVM artifacts and validation checkpoints, but its progressive-disclosure structure depends on references that do not exist, and its single inline code example is not copy-paste ready.
Suggestions
Create or restore the referenced files (docs/calling-conventions.md, codegen.md, tablegen.md) or inline the essential terminology so the skill is not dependent on missing resources.
Replace the 'ParamAttrBuilder...' placeholder with a complete, executable parameter-attribute snippet covering the common sret/byval cases.
Add an explicit validate→fix→retry feedback loop around TableGen regeneration and ISel lowering (e.g., rebuild, run lit, on mismatch re-check CCState/CCValAssign) to raise workflow clarity.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Lean and assumes Claude's LLVM knowledge without padding; the Scope boundary and Out-of-tree summary restate the same in-tree-vs-out-of-tree point, a minor redundancy that could be tightened. | 4 / 5 |
Actionability | Concrete file paths, function names (LowerFormalArguments/LowerCall/LowerReturn), and commands (cmake --build, llvm-lit, verifyModule, llc); not a 5 because the one inline snippet uses a 'ParamAttrBuilder...' placeholder and is not copy-paste ready. | 4 / 5 |
Workflow Clarity | Clear Step 0–7 sequence with validation checkpoints (verifyModule, lit, exhaustiveness warnings) and a review checklist; not a 5 because feedback loops for TableGen/lowering mismatches are only warned about ('silent ABI bugs') rather than expressed as validate→fix→retry. | 4 / 5 |
Progressive Disclosure | Sections are well-organized and references are clearly signaled one level deep, but every referenced path (calling-conventions.md, codegen.md, tablegen.md, add-intrinsic/SKILL.md) is missing — including the terminology doc Step 0 defers to — so the disclosure structure has real holes. | 3 / 5 |
Total | 15 / 20 Passed |