Content
77%Scale 1-3Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
This is a high-quality, actionable skill that provides a comprehensive step-by-step guide for adding an LLVM IR intrinsic. Its greatest strengths are the fully executable code examples at every step and the clear sequential workflow with validation checkpoints. The main weakness is that it's quite long for a SKILL.md file, with reference tables and dual-path explanations (GlobalISel + SelectionDAG) that could be split into separate files for better progressive disclosure.
Suggestions
Move the properties table and type tokens table to a separate REFERENCE.md file, linking to it from the main skill with a brief summary
Consider splitting the target-specific lowering (Step 3) into a separate LOWERING.md since it covers two distinct paths (GlobalISel and SelectionDAG) and is optional for generic intrinsics
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The skill is mostly efficient and covers a complex multi-step process, but includes some unnecessary explanation (e.g., the full type tokens table, the common properties table could be trimmed or referenced externally). The tables are useful reference material but make the document quite long. It respects Claude's intelligence in most places but could be tighter. | 2 / 3 |
Actionability | Every step includes fully executable, copy-paste-ready code examples — TableGen definitions, CMake commands, C++ lowering code, IRBuilder usage, Verifier checks, lit tests, and InstCombine folds. The examples are concrete and specific with real LLVM 22 API calls. | 3 / 3 |
Workflow Clarity | The 8-step workflow (Steps 0-7) is clearly sequenced with logical progression from definition to testing. Validation is explicitly addressed: Step 2 includes regeneration verification, Step 5 covers verifier rules, Step 6 includes running verify passes before optimization passes, and the 'Common mistakes' section serves as a validation checklist. The note about rebuilding intrinsics_gen acts as a critical checkpoint. | 3 / 3 |
Progressive Disclosure | The content is well-structured with clear headers and a logical flow, but it's a monolithic document with substantial inline reference material (type tokens table, properties table, both GlobalISel and SelectionDAG paths) that could be split into separate reference files. For a skill of this length (~200 lines), some content would benefit from being externalized with clear links. | 2 / 3 |
Total | 10 / 12 Passed |