128-java-generics

Use when you need to review, improve, or refactor Java code for generics quality — including avoiding raw types, applying the PECS (Producer Extends Consumer Super) principle for wildcards, using bounded type parameters, designing effective generic methods, leveraging the diamond operator, understanding type erasure implications, handling generic inheritance correctly, preventing heap pollution with @SafeVarargs, and integrating generics with modern Java features like Records, sealed types, and pattern matching. This should trigger for requests such as Improve the code with Generics; Apply Generics; Refactor the code with Generics; Improve generic type safety in Java APIs; Fix raw types and unchecked casts in Java code. Part of Plinth Toolkit

Quality

—

Does it follow best practices?

Impact

—

No eval scenarios have been run

Securityby

Passed

No known issues

Quality

Content

70%

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

A well-structured overview skill with clear workflow validation and clean one-level-deep progressive disclosure; the body is slightly redundant and delegates the concrete generics code to the reference rather than showing it.

Suggestions

Consolidate the duplicated compile/verify/stop guidance: state it once in the Workflow and have Constraints reference it, to tighten conciseness.

Add one short representative good/bad Java snippet inline (e.g. raw type -> parameterized) so the body gives directly actionable generics guidance rather than only pointing to the reference.

Remove or shorten the 'When to use this skill' section since its trigger phrases already appear verbatim in the description.

Dimension	Reasoning	Score
Conciseness	The body is lean and assumes Claude's Java knowledge, but the Constraints and Workflow sections repeat the same compile/verify/stop-on-failure guidance, and 'When to use this skill' duplicates trigger phrases already in the description.	2 / 3
Actionability	It gives concrete executable commands (./mvnw compile, mvn clean verify), but the core generics-refactoring guidance is deferred to the reference rather than shown inline, leaving the body's task-specific steps as directions ('apply refactorings', 'identify raw types').	2 / 3
Workflow Clarity	A clear 4-step sequence with explicit validation checkpoints (compile before, verify after) and a blocking stop-on-failure condition reinforced in Constraints, matching the explicit-checkpoint-with-feedback anchor.	3 / 3
Progressive Disclosure	The body is a concise overview pointing to a single one-level-deep reference (references/128-java-generics.md, verified present with 17 organized examples), signaled via a dedicated Reference section with a working link.	3 / 3
	Total	10 / 12 Passed

Description

90%

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

A rich, highly specific Java-generics description with strong trigger phrasing and clear what/when coverage; the only issue is second-person voice ('Use when you need to...') in the opening, which the rubric penalizes on specificity.

Suggestions

Rephrase the opening to third person to avoid the voice penalty, e.g. 'Use when reviewing, improving, or refactoring Java code for generics quality' (drop 'you need to').

Consider trimming the long mid-sentence capability list slightly; the explicit trigger phrases already convey most of the scope.

Dimension	Reasoning	Score
Specificity	The description lists many concrete actions ('avoiding raw types, applying the PECS principle..., preventing heap pollution with @SafeVarargs'), which is score-3 quality, but it opens with second-person voice ('Use when you need to review...'), so the rubric's voice penalty reduces specificity by one.	2 / 3
Completeness	It clearly answers both what (the full capability list) and when (an explicit 'Use when...' clause plus 'This should trigger for requests such as...'), matching the both-what-and-when anchor.	3 / 3
Trigger Term Quality	It provides explicit natural trigger phrasings users would say ('Improve the code with Generics; Apply Generics; Refactor the code with Generics; ... Fix raw types and unchecked casts in Java code'), giving good coverage of natural terms.	3 / 3
Distinctiveness Conflict Risk	It targets a clear Java-generics niche with distinctive technical triggers (PECS, raw types, @SafeVarargs, type erasure) that are unlikely to fire for unrelated skills.	3 / 3
	Total	11 / 12 Passed

Validation

100%

Warnings & errors only

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 16 / 16 Passed

Validation for skill structure

No warnings or errors.

Repository: jabrena/plinth
Commit: aaee915

Reviewed: 1 day ago

Table of Contents

Discovery Implementation Validation

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.