128-java-generics

Use when you need to review, improve, or refactor Java code for generics quality — including avoiding raw types, applying the PECS (Producer Extends Consumer Super) principle for wildcards, using bounded type parameters, designing effective generic methods, leveraging the diamond operator, understanding type erasure implications, handling generic inheritance correctly, preventing heap pollution with @SafeVarargs, and integrating generics with modern Java features like Records, sealed types, and pattern matching. This should trigger for requests such as Improve the code with Generics; Apply Generics; Refactor the code with Generics; Improve generic type safety in Java APIs; Fix raw types and unchecked casts in Java code. Part of Plinth Toolkit

Quality

88%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide

Securityby

Passed

No findings from the security scan

Quality

Content

85%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

A well-structured skill body with strong workflow validation and clean progressive disclosure into a single reference file. The main weakness is minor redundancy between the When-to-use/Constraints sections and the description/Workflow, plus a vague 'apply refactorings' step.

Suggestions

Remove the duplicate trigger-phrase list in 'When to use this skill' (it already appears verbatim in the description) or consolidate into a single location to save tokens.

Tighten the 'Apply generics refactorings' workflow step with a concrete pointer to which reference sections to draw patterns from, rather than 'Implement selected generic type and API improvements'.

Avoid restating the compile/verify commands in both the Constraints block and the Workflow; reference one from the other to reduce redundancy.

Dimension	Reasoning	Score
Conciseness	The body is lean with no tutorializing of concepts Claude already knows, but the 'When to use this skill' section duplicates the description's trigger phrases and the Constraints block repeats the compile/verify commands also stated in the Workflow — minor trimmable redundancy.	4 / 5
Actionability	Concrete, copy-paste-ready commands ('./mvnw compile', 'mvn clean verify') and a clear reference pointer are provided; the 'Apply generics refactorings' step remains somewhat vague and no inline code examples appear, but concrete patterns are appropriately deferred to the reference file.	4 / 5
Workflow Clarity	A four-step sequence with explicit validation checkpoints — mandatory compile-before with 'stop immediately if compilation fails' feedback loop and a verify-after step — matches the anchor for clear sequencing with error-recovery feedback loops.	5 / 5
Progressive Disclosure	SKILL.md is a well-sectioned overview (What is covered, Scope, Constraints, When to use, Workflow, Reference) with the 60KB of detailed examples in a single one-level-deep, clearly signaled reference file that exists in the bundle.	5 / 5
	Total	18 / 20 Passed

Description

92%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

A strong, comprehensive description that explicitly covers capabilities, trigger conditions, and a distinctive niche. Slight room to broaden trigger-term synonyms beyond repetitive 'Generics' phrasings.

Suggestions

Add synonyms such as 'type safety' or 'parameterized types' to the trigger phrases so the skill surfaces for a wider range of natural user requests.

Consider trimming the long capability list slightly; a few of the sub-areas (e.g., 'generic naming conventions') add length without materially improving trigger precision.

Dimension	Reasoning	Score
Specificity	Enumerates many concrete actions — 'avoiding raw types, applying the PECS principle, using bounded type parameters, leveraging the diamond operator, preventing heap pollution with @SafeVarargs, integrating with Records/sealed types/pattern matching' — giving comprehensive coverage of the generics domain.	5 / 5
Completeness	Explicitly answers both what (review/improve/refactor Java generics across listed sub-areas) and when ('Use when you need to...' plus 'This should trigger for requests such as...') with concrete trigger phrases.	5 / 5
Trigger Term Quality	Provides natural trigger phrases users would say ('Improve the code with Generics; Apply Generics; Refactor the code with Generics; Fix raw types and unchecked casts'), but the variations are narrow repetitions of 'Generics' and omit common synonyms like 'type safety' or 'parameterized types'.	4 / 5
Distinctiveness Conflict Risk	Targets a clear niche (Java generics quality) with distinctive, generics-specific triggers and 'Part of Plinth Toolkit' branding, minimizing overlap with general Java code-review skills.	5 / 5
	Total	19 / 20 Passed

Validation

100%

Warnings & errors only

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 16 / 16 Passed

Validation for skill structure

No warnings or errors.

Repository: jabrena/plinth
Path: skills/128-java-generics/SKILL.md
Commit: 77b8825

Reviewed: about 23 hours ago

Table of Contents

Discovery Implementation Validation

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.