CtrlK
BlogDocsLog inGet started
Tessl Logo
SkillPublic

factory-self-review

Review and test a Factory work item's pushed branch before any pull or merge request exists, then record the verdict that sends it back to Building or on to open the change request

72

Quality

90%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide
SecuritybySnyk

Low

Low-risk findings worth noting

SKILL.md
Quality
Evals
Security

Quality

Content

92%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

A lean, tightly orchestrated instruction body: exact commands, a precisely scoped reuse of the factory-review skill, explicit failure and retry paths, and a well-specified terminal action. The only minor improvement is giving the fetch/reset step as an exact command like the other git operations.

DimensionReasoningScore

Conciseness

Every sentence is instruction: role guard, scope of the review bar, exact git commands, report format, verdict call semantics, and stop condition. No concept explanations, no padding, and full assumption of Claude's competence — a clean match for the lean/efficient anchor 5.

5 / 5

Actionability

Concrete and executable where it counts: `git rev-parse --abbrev-ref HEAD`, `git rev-parse HEAD`, `git merge-base HEAD origin/<default branch>`, review range `base...HEAD`, and the `factory_record_review_verdict` call with named arguments (`verdict`, `reviewedHeadSha`, `findings`). The gap keeping it from anchor 5 is that the fetch/reset in Checkout step 1 is described in prose ("Fetch the work branch... from origin and reset the checkout") rather than as a copy-paste-ready command.

4 / 5

Workflow Clarity

The sequence is explicit and guarded: role guard → review bar (with precisely scoped phases of `factory-review`) → numbered checkout with failure handling ("If it does not exist on origin, the builder never pushed: request changes") → structured report → verdict call → final message and stop. Validation checkpoints are explicit (quality gate, confirming previous findings fixed on later rounds) and feedback loops exist (retry the verdict call only if rejected with the stated reason addressed; request-changes rounds), matching anchor 5.

5 / 5

Progressive Disclosure

The body is under 50 lines with well-organized sections and no bundle files to split; its single external dependency (`factory-review`, loaded via `skill_read`) is a clearly signaled, one-level-deep reference with an exact statement of which parts apply. Per the rubric's simple-skill guidance, this warrants anchor 5.

5 / 5

Total

19

/

20

Passed

Description

83%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

A strong, dense description that states concrete actions and both outcomes of the verdict, names its niche unambiguously, and includes an explicit precondition. Its only weakness is that the 'when' reads as a workflow stage rather than invocation trigger phrasing, and it offers little synonym variation for discovery.

DimensionReasoningScore

Specificity

The description lists multiple concrete actions covering the full workflow — "Review and test a Factory work item's pushed branch", "record the verdict", "sends it back to Building or on to open the change request" — with no gaps within its scope. It matches the anchor for multiple specific concrete actions with comprehensive coverage, and is not score 4 because there are no minor gaps in what the skill does.

5 / 5

Completeness

Both parts are answered: what ("Review and test a Factory work item's pushed branch... then record the verdict") and when ("before any pull or merge request exists"). The when is explicit but woven into the action narrative as a workflow precondition rather than framed as invocation trigger guidance ("Use when..." or equivalent), which is what anchor 5 requires; it is clearly above anchor 3, where when is missing or only weakly implied.

4 / 5

Trigger Term Quality

Domain-natural terms are well covered: "review", "test", "pushed branch", "pull or merge request", "verdict", "change request", "Building". It falls short of the anchor 5 example's synonym/variation breadth (e.g., no "self-review", "pre-PR", or stage-language variations), but clearly exceeds anchor 3's 'missing common variations' level.

4 / 5

Distinctiveness Conflict Risk

The description carves out a clear niche — a Factory-specific pre-PR/MR branch review tied to the Building/Review/change-request lifecycle — so triggers are distinct and conflict risk with generic review or code-review skills is minimal, matching anchor 5.

5 / 5

Total

18

/

20

Passed

Validation

100%

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 16 / 16 Passed

Validation for skill structure

No warnings or errors.

Repository

mastra-ai/mastra

Path

mastracode/factory/factory-skills/factory-self-review/SKILL.md

Reviewed

Table of Contents

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.