CtrlK
BlogDocsLog inGet started
Tessl Logo
SkillPublic

factory-self-review

Review and test a Factory work item's pushed branch before any pull or merge request exists, then record the verdict that sends it back to Building or on to open the change request

Quality

88%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide
SecuritybySnyk

Low

Low-risk findings worth noting

SKILL.md
Quality
Evals
Security

Quality

Content

92%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

A tight, well-sequenced instruction skill: it composes an existing review skill for its criteria, gives concrete git and tool-call commands, and builds in failure handling and a rejection feedback loop. The only shortfalls are small actionability gaps, chiefly leaving the default branch for merge-base unspecified.

DimensionReasoningScore

Conciseness

The ~40-line body is lean and assumes competence: it delegates review criteria to factory-review via skill_read instead of re-explaining them, gives bare git commands with no tutorial padding, and every sentence instructs. It matches anchor 5 ("every token earns its place") rather than 4, since there is no over-explanation left to trim.

5 / 5

Actionability

Guidance is mostly executable: copy-paste commands (`git rev-parse --abbrev-ref HEAD`, `git merge-base HEAD origin/<default branch>`, `base...HEAD`), a fully specified `factory_record_review_verdict` call with argument names, and a concrete report format. Minor gaps hold it at anchor 4 rather than 5 — the default branch is never determined for the reader, and steps like "load the category guidance" resolve only through the referenced skill's phases.

4 / 5

Workflow Clarity

The sequence is explicit (role guard → load criteria → checkout → report → verdict → stop) with validation checkpoints and feedback loops: "If it does not exist on `origin`, the builder never pushed: request changes", "confirm each one is fixed on this head before looking for new problems", and the verdict "repeated only if rejected and only with the stated reason addressed". The workflow is read/test/record (pushing and committing are explicitly forbidden), so the destructive/batch cap does not apply; anchor 5 fits.

5 / 5

Progressive Disclosure

The skill is under 50 lines with no bundle files, well-organized into scoped sections, and its only external dependency is a single clearly-signaled one-level reference ("Load `factory-review` with `skill_read`"). Per the rubric's simple-skill guideline this matches anchor 5.

5 / 5

Total

19

/

20

Passed

Description

78%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

A specific, niche-scoped description that names concrete actions and both PR/MR variants of the trigger condition. Its main weakness is the "when" side: the applicability condition is stated but thin compared to the body's actual role/stage guard, and common natural phrasings like "self-review" are absent.

Suggestions

Make the trigger condition more explicit and complete, e.g. append "Use when a Factory Work card is in the review stage with role='review' and no pull or merge request has been opened" so the when-clause matches the body's role guard.

Add natural synonyms users would say, such as "self-review", "pre-PR review", or "verify the builder's branch", to strengthen trigger term coverage.

Mention the deliverable in the what-clause — e.g. "...and write the findings report the builder acts on" — to close the coverage gap in stated capabilities.

DimensionReasoningScore

Specificity

The description lists several concrete actions — "Review and test a Factory work item's pushed branch", "record the verdict", "sends it back to Building or on to open the change request" — with a conditional routing outcome. It matches anchor 4 rather than 5 because coverage has minor gaps (e.g., producing the findings report is never mentioned), and it exceeds anchor 3's 1-2 concrete actions.

4 / 5

Completeness

The "what" is clear (review, test, record verdict with routing), and a "when" is explicitly stated via "before any pull or merge request exists". It sits at anchor 4 rather than 5 because the when-condition could be more specific — the body's role/stage trigger (role="review", stage review, no open PR) is not reflected, and there is no "Use when..." style trigger phrase.

4 / 5

Trigger Term Quality

Good natural keyword coverage: "review", "test", "branch", "pull or merge request" (covering both PR and MR variants), and "Factory work item". A few natural terms are missing (e.g., "self-review", "pre-PR"), which keeps it at anchor 4 rather than 5, but coverage clearly exceeds anchor 3's partial keyword set.

4 / 5

Distinctiveness Conflict Risk

"Factory work item's pushed branch before any pull or merge request exists" carves a clear niche with distinct triggers, distinct from generic code-review or PR-review skills. Overlap risk is minimal, matching anchor 5 rather than anchor 4's "minor overlap risk with closely related skills".

5 / 5

Total

17

/

20

Passed

Validation

100%

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 16 / 16 Passed

Validation for skill structure

No warnings or errors.

Repository

mastra-ai/mastra

Path

mastracode/factory/factory-skills/factory-self-review/SKILL.md

Reviewed

Table of Contents

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.