Content
90%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
An exceptionally dense, repo-specific reference that assumes Claude's competence and provides copy-paste-ready commands, code, and diagnostics throughout. The only notable gaps are the lack of an explicit verification step in the fixture-creation workflow and inline fixture/mock detail that could be split into a reference file.
Suggestions
Add an explicit validation step to the add-fixture workflow (e.g., 'screenshot the new fixture via mcp_component-exp_screenshot and confirm both Dark and Light variants render before setting blocksCi').
Move the 11-row fixture-ID table and the per-type mock-data requirements into a references file, keeping SKILL.md as an overview with a clearly signaled pointer.
Make the layout-debugging loop an explicit numbered validate → fix → re-diagnose sequence rather than relying on the reader to combine the eval diagnostics with the common-issues table.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Nearly every line carries non-derivable repo knowledge — file paths, interface names, fixture IDs, exact mock methods, CI gate labels — with no explanations of concepts Claude already knows and no padding. This matches anchor 5 ('lean and efficient; assumes Claude's competence; every token earns its place') rather than 4, which would require identifiable over-explanation to trim. | 5 / 5 |
Actionability | Guidance is fully executable and copy-paste ready: runnable commands ('./scripts/test.sh --grep "applyStorageSourceFilter|customizationCounts"', 'pnpm run typecheck-client'), complete code blocks for adding a tab fixture and for @playwright/cli eval diagnostics, and exact mock method names per customization type. It matches anchor 5's 'copy-paste ready code or commands; specific examples cover the common cases'. | 5 / 5 |
Workflow Clarity | The main workflows are clearly sequenced with most checkpoints present: the five-layer sync table for API changes with 'verify both core and sessions registrations compile', CI regression gates that 'fail the CI status check' on screenshot changes, and a symptom/root-cause/fix table with error-recovery guidance for layout debugging. It falls short of anchor 5 because the add-fixture workflow has no explicit validate-rendered-output step, and the debugging loop's fix-then-recheck cycle is implied by the table rather than an explicit feedback loop. | 4 / 5 |
Progressive Disclosure | No bundle files exist, so this is a single-file skill; external pointers (the spec at 'src/vs/sessions/AI_CUSTOMIZATIONS.md', '.github/instructions/ai-customization.instructions.md', and the 'component-fixtures'/'sessions'/'launch' skills) are clearly signaled with purpose and are one level deep. This matches anchor 4 ('good structure; most content is appropriately placed; minor organization gaps') rather than 5 because the 11-row fixture-ID table and the detailed mock-service requirements are inline content that could plausibly live in a reference file. | 4 / 5 |
Total | 18 / 20 Passed |