CtrlK
BlogDocsLog inGet started
Tessl Logo

tae-test-review

Review and authoring guidance for new/changed tests in the Fenix TAE efficiency framework (mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/ui/efficiency). Use when reviewing a diff, PR, or Phabricator revision that adds or modifies files under that path — page objects, selectors, navigation edges, or test files. Also use when authoring a new test and self-checking before submission, when asked to check a test against TAE conventions, classify a test (presence/interaction/behavior), or judge whether a helper belongs in a page object vs. BasePage. Also use when auditing a converted test for assertion parity against the legacy test it replaces. Applies the framework's principles and anti-patterns as a review rubric with severity tiers.

75

Quality

94%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide

SecuritybySnyk

Passed

No findings from the security scan

SKILL.md
Quality
Evals
Security

Quality

Content

88%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

A strong, highly actionable review rubric with concrete examples, sequenced workflows, and validation checkpoints. Its only weak spots are structural redundancy across sections and a monolithic file with no bundle-based progressive disclosure.

Suggestions

Consolidate the Behavior-test exception and parity-audit rules into one canonical section and have other sections only cross-reference it, to cut repeated tokens.

Move the interaction/verification primitive tables and the SelectorStrategy table into a references/ bundle file, keeping only the decision-time essentials inline in SKILL.md.

DimensionReasoningScore

Conciseness

Information-dense with no basic-concept padding and explicit cross-references, but several rules recur across 'Principles', 'Anti-patterns', and 'Conducting a review' (e.g. the Behavior-test exception and parity audit each appear 3+ times), which could be tightened.

4 / 5

Actionability

Copy-paste-ready Kotlin examples (rejected/accepted worked test, three-phase structure, navigation init, @Converted annotation), concrete primitive/strategy tables, and specific shell commands ('settings put secure stylus_handwriting_enabled 0') cover the common review cases.

5 / 5

Workflow Clarity

Clear review sequence (Scope first → Severity tiers → Migration triage → Parity audit → 11-step checklist) with explicit validation (parity 'no third option') and a decision feedback loop (the 5-question cost-of-fix gate), plus 'Before you write' and 'Adding a new page' checklists.

5 / 5

Progressive Disclosure

Good section structure with a well-signaled one-level-deep navigation table to in-tree docs, but the SKILL.md is a large monolithic single file with no bundle files offloading the primitive/strategy reference tables that could live separately.

4 / 5

Total

18

/

20

Passed

Description

100%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

A model description: third-person voice, concrete actions, explicit multi-clause 'Use when' triggers, and a tightly scoped niche that minimizes conflict risk. Both what and when are answered with concrete trigger phrases.

DimensionReasoningScore

Specificity

Lists multiple concrete actions — 'reviewing a diff, PR, or Phabricator revision', 'authoring a new test and self-checking', 'classify a test (presence/interaction/behavior)', 'judge whether a helper belongs in a page object vs. BasePage', 'auditing a converted test for assertion parity' — giving comprehensive coverage of the skill's capabilities.

5 / 5

Completeness

Explicitly states what ('Review and authoring guidance... Applies the framework's principles and anti-patterns as a review rubric with severity tiers') and when ('Use when reviewing a diff, PR, or Phabricator revision...', 'Also use when authoring...', 'Also use when auditing...') with concrete trigger phrases.

5 / 5

Trigger Term Quality

Natural domain terms a user would actually say (diff, PR, Phabricator revision, page objects, selectors, navigation edges, BasePage) appear with synonyms; the path and 'presence/interaction/behavior' classification are exactly the vocabulary of this framework.

5 / 5

Distinctiveness Conflict Risk

Scoped to a specific in-tree path and framework (Fenix TAE efficiency) with distinctive triggers (Phabricator revision, page object vs. BasePage, assertion parity), making conflict with unrelated skills minimal.

5 / 5

Total

20

/

20

Passed

Validation

93%

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 15 / 16 Passed

Validation for skill structure

CriteriaDescriptionResult

skill_md_line_count

SKILL.md is long (742 lines); consider splitting into references/ and linking

Warning

Total

15

/

16

Passed

Repository
mozilla/firefox-aidev-plugins
Reviewed

Table of Contents

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.