Post-implementation PR prep for Novu feature branches — quality passes, commit/PR hygiene, CI triage, and review feedback. Use after feature work is done, when the user asks to prepare a PR, ship a branch, fix CI, address review comments, or babysit a pull request before merge.
99%
Does it follow best practices?
Run evals on this skill
Adds up to 20 points to the overall score
Low
Low-risk findings worth noting
Run this after implementation is complete on a feature branch. Do not replan or expand scope unless review/CI exposes a real gap.
cursor/<short-description> off next).nv-XXXX, NV-XXXX).Copy and track:
PR prep progress:
- [ ] 1. Scope & diff sanity
- [ ] 2. Quality passes
- [ ] 3. Security check (if shared/multi-tenant)
- [ ] 4. Local validation
- [ ] 5. Commit hygiene
- [ ] 6. Open or update PR
- [ ] 7. CI triage & fix
- [ ] 8. Review comments
- [ ] 9. Merge-ready checkgit status, git diff, git log next..HEAD --oneline.Run in order when the branch is non-trivial:
Skip or shorten for tiny hotfixes the user explicitly scoped.
Required when the PR touches API or Worker related code and DAL.
Check the diff against "Sensitive spots" and "Hot path" in the root AGENTS.md, plus these Novu-specific items:
Name each sensitive spot the diff touches in the PR body (step 6).
If P0 cross-tenant risk is found: fix + add e2e coverage before opening/updating PR.
If the Linear ticket or its spec says how to validate the change, run those checks first. Then pick the smallest check that proves the change:
| Change type | Check |
|---|---|
| API / libs type errors | pnpm --filter @novu/api-service build |
| Shared libs | pnpm build (only if packages/ or enterprise/ touched) |
| New/changed e2e | Load run-api-e2e-tests and run the specific file |
| Dashboard UI | Open the changed page in a browser, compare it with the design linked in the ticket, take a screenshot |
| Crosses services (API → worker → provider, email) | Load verify-in-box and drive the change on the box |
Report failures; fix before push when deterministic. Keep each check and what it showed for step 6.
type(scope): concise why fixes NV-XXXdashboard, api-service, worker, shared, etc.Read .cursor/rules/pullrequest.mdc before creating.
**next**type(scope): Description fixes NV-XXXgh pr create / update existing PR — do not push unless user askedIf branch diverged from next: fetch origin, merge/rebase, resolve simple conflicts preserving both intents; report complicated intent conflicts.
When checks fail:
ci-investigator subagent per failing check in parallel (single message, all Task calls together).Load get-pr-comments skill when user asks to address PR feedback.
Before calling done:
enterprise/ changed, matching enterprise PR exists and both PR bodies link each other (do not "fix" submodule sync test in main repo)Optional: load babysit skill when user asks to keep iterating until merge-ready.
thermo-nuclear-code-quality-review — pre-PR quality auditdeslop — remove AI slop from branch diffget-pr-comments — triage review feedbackbabysit — loop until merge-readynovuhq/novu
50f3037
If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.