Content
47%Weight 40%Scale 1-3Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
The skill has an excellent mandatory search->validate workflow with a real feedback loop, but it is dominated by a ~3,350-line inline TypeScript type dump that wrecks token efficiency and should be split into a reference file. Actionability is medium: concrete script commands exist, but recipe code is deferred to dynamic search.
Suggestions
Move the inline TypeScript component type definitions (lines 60-3414) into a bundled reference file (e.g. references/hydrogen-types.d.ts) and link to it from SKILL.md; drop the unrelated type-fest utility doc comments entirely, since they bloat the context with content already available in the package itself.
Add 1-2 concrete, copy-paste-ready JSX recipe examples inline (e.g. a minimal cart fetch and render) so the skill is actionable without requiring a successful search_docs call first.
Consolidate the duplicated tool-call instructions (the top 'Required Tool Calls' block and the bottom 'MANDATORY: Search/Validate' sections) into a single workflow block to remove redundancy.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is ~3,350 lines of inline TypeScript type definitions (lines 60-3414), including lengthy type-fest utility doc comments (UnionToIntersection, KeysOfUnion) unrelated to Hydrogen usage — a monolithic dump of content Claude could read from the package's own .d.ts, matching the 'verbose; padded with unnecessary context' anchor. | 1 / 3 |
Actionability | Concrete executable commands are present ("scripts/search_docs.mjs", "scripts/validate.mjs --code '...'" with specific flags), but the actual recipe/JSX code examples are deferred to dynamic search rather than shown inline, leaving key details missing per the anchor-2 'some concrete guidance but incomplete' criterion. | 2 / 3 |
Workflow Clarity | A clearly numbered workflow (search -> write -> validate -> "If validation fails: search for the error type, fix, re-validate (max 3 retries)" -> "Return code only after validation passes") with an explicit validation checkpoint and error-recovery feedback loop, matching the anchor for a clear sequenced process. | 3 / 3 |
Progressive Disclosure | Some structure exists (section headers, real bundle scripts, an external cookbook doc path), but ~3,350 lines of type definitions that should live in a separate reference file are dumped inline — the textbook anchor-2 anti-pattern of 'API reference that could be in a separate file'; not anchor 1 because navigation/structure is present. | 2 / 3 |
Total | 8 / 12 Passed |