Content
85%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A tight, well-structured review checklist that assumes Claude's competence and provides concrete, Convex-specific checks with explicit severity mappings and a clear multi-pass workflow. The main weaknesses are minor: duplication between the Workflow and Rules sections costs tokens, and the resource-ownership check plus the report step lack concrete patterns or an example output format.
Suggestions
Merge the Workflow passes and Rules into a single checklist where each check carries its severity inline (e.g., "Flag .filter() on DB queries as Important — it is a full table scan"), removing the duplicated .filter(), Date.now(), validator, and internal.*/api.* entries.
Make the ownership check concrete: specify the expected pattern (e.g., fetch the document with ctx.db.get(id) and compare its userId against the authenticated identity) instead of the generic "verify resource ownership before reads/writes".
Add a brief example of the expected report output — one finding showing severity, why it matters, and suggested fix — so the "Report findings grouped by severity" step has a concrete format to follow.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is lean, assumes Claude's competence (no explanation of what Convex is, drops API names like ctx.auth.getUserIdentity() and withIndex without preamble), and every check is actionable. It is not a 5 because the Workflow passes and the Rules section repeat the same checks — .filter(), Date.now(), validators, and internal.*/api.* each appear twice — where a merged checklist with inline severity ("Flag X as Critical because Y") would be tighter and avoid cross-referencing two sections. | 4 / 5 |
Actionability | Guidance is highly concrete for an instruction-only skill: specific APIs ("ctx.auth.getUserIdentity()", ".filter()", "withIndex", "Date.now()", ".collect()", "internal.* not api.*"), a hard threshold ("<8192 elements"), and explicit severity mappings. It stops short of a 5 because "verify resource ownership before reads/writes" gives no concrete pattern for how to verify ownership, and there is no example of the expected finding/report format despite instructing findings be grouped by severity. | 4 / 5 |
Workflow Clarity | The three passes are clearly sequenced (security, then performance, then code quality) and conclude with an explicit reporting step ("Report findings grouped by severity; explain why each issue matters and suggest a fix"). This is a read-only review skill, so destructive/batch validation caps do not apply, and each pass functions as an explicit checklist for the process. | 5 / 5 |
Progressive Disclosure | The skill is under 50 lines, self-contained, and has no bundle files (no references/, scripts/, or assets/ directories exist), so there is nothing that belongs in external files. Sections (Workflow, Rules) are well-organized, matching the rubric's simple-skill exception for scoring 5 with well-organized sections alone. | 5 / 5 |
Total | 18 / 20 Passed |