Content
85%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
An exceptionally actionable, repo-specific skill with an explicit six-step workflow, layered validation via mandated tests, and precise code/file anchors. Its two weaknesses are redundancy (range handling, validation ownership, and dot-notation are each explained multiple times) and a monolithic 350-line body that inlines reference-grade tables instead of splitting them into a references/ bundle file.
Suggestions
Move the stable reference material — the filter grammar block, the API-layer type table, the predicate mapping table, and the error-message catalog — into a references/ file (e.g. references/filter-reference.md) and keep a condensed cheat-sheet in SKILL.md, one level deep.
Deduplicate the range-query semantics and 'validation belongs on pkg/filter' explanations, each of which currently appears in three sections ('Multi-filter semantics'/'Range queries', architecture rules, and 'Important Reminders').
Fix the Step 6 count ('three additional layers' followed by four numbered items) and consider adding the concrete test command (e.g. go test ./...) so the validation checkpoints are runnable as written.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Dense, terse, and almost entirely repo-specific knowledge (type tables, operator grammar, security caps) with no generic Go/HTTP tutorials. It is not a 5 because several topics are repeated across sections — range-splitting appears in 'Multi-filter semantics', Step 4, and the 'Range queries' gotcha; validation ownership is stated three times; dot-notation in three places — which could be consolidated; not a 3 because the length reflects genuine reference material rather than padding. | 4 / 5 |
Actionability | Copy-paste-ready Go snippets with real imports, exact file paths with line numbers (e.g. "api/v3/filters/parse.go:16-19", "openmeter/customer/customer.go:296"), concrete commands ("make gen-api", "httptest.NewRequest"), and representative error-message strings. Coverage spans handler, service, adapter, and test layers. | 5 / 5 |
Workflow Clarity | Six clearly ordered steps, each naming its target files, with mandatory validation checkpoints ("ALWAYS add service level tests") that enumerate the exact test cases to cover (shorthand, eq, contains, oeq, range, unknown-field 400, mutually-exclusive 400, dot-notation) and an Error Handling section that maps error messages to causes. A 4 would require missing or merely implicit checkpoints; the only blemish is cosmetic (Step 6 says 'three additional layers' then lists four). | 5 / 5 |
Progressive Disclosure | Sections are well-organized with clear headers, and references to repo source files are clearly signaled with path:line citations, but no bundle files exist and roughly 150 lines of stable reference material (filter grammar, type-mapping tables, error-message catalog) are inlined in SKILL.md where the rubric expects them to live one level deep in a references/ file. Not a 4 because the bulk reference content is inline rather than split out; not a 2 because structure and signaling are good, not buried. | 3 / 5 |
Total | 17 / 20 Passed |