Content
100%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A tight, high-signal skill body: imperative rules, a verified executable scanner, copy-paste refactoring patterns, an explicit re-validation loop, and a review checklist, all with zero padding. The public-vs-internal classification step and compat boundary pattern handle the only real ambiguity in the task.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is dense imperative rules, commands, and minimal before/after snippets; it never explains concepts Claude already knows (no TypeScript tutorials, no rationale padding). The only prose is one short 'why' sentence in the intro, which earns its place; this fits the 'every token earns its place' anchor rather than the score-4 'minor trimming needed' anchor. | 5 / 5 |
Actionability | Guidance is fully executable: a real scanner command with variants (`bun .agents/skills/nullable-new-params/scripts/find-new-optional-params.ts origin/main...HEAD`, `--cached`), concrete Before/After type and parameter examples, explicit caller patterns (`field: null`, `maybeValue ?? null`), a boundary conversion (`const internal = publicValue ?? null`), and a build command (`bunx turbo run make --filter='<package-name>'`). The referenced script exists in the bundle and is a working scanner, so nothing is pseudocode. | 5 / 5 |
Workflow Clarity | The 7-step workflow (scan → classify → refactor → update callers → update implementation → public compat → verify) has an explicit validation loop ("Run the scanner again until only intentional public API exceptions remain"), a verification command, and a closing review checklist — matching the anchor requiring feedback loops and checklists. Not the score-4 anchor, since no checkpoint is missing. | 5 / 5 |
Progressive Disclosure | Sections (Rule, Workflow, Review checklist) are well organized, everything inline is short and needed up front, and the single bundle file (scripts/find-new-optional-params.ts) is real, referenced one level deep, and demonstrated with usage variants. There is no content that belongs in a separate file and no nested references, so it fits the clear-overview/one-level-deep anchor. | 5 / 5 |
Total | 20 / 20 Passed |