Content
75%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A strong, well-structured instruction-only skill: it is lean, directive, organized into clear sections, and densely packed with specific API names for modern macOS Liquid Glass work, with a sequenced workflow and a review checklist. The main gaps are the absence of any code examples for the non-obvious custom-glass APIs, validation phrased abstractly rather than as a concrete check, and sibling-skill references given as bare names rather than links.
Suggestions
Add one short SwiftUI snippet each for the two non-obvious APIs — `glassEffect` with an explicit custom shape, and a `GlassEffectContainer` + `glassEffectID` + `@Namespace` morph — so the custom-glass guidance is copy-paste ready rather than prose-only.
Make the workflow's validation step concrete: replace 'Validate that glass grouping, transitions, icon treatment, and foreground activation are visually coherent' with specific checks (e.g., confirm elements share one `GlassEffectContainer`, confirm morph targets use stable `glassEffectID`s, confirm the window is frontmost/keyboard-usable).
Tighten the Overview, which restates content covered later in 'App Structure' and 'Guardrails' (system materials vs. custom chrome), and add paths or links for the sibling skills in 'When To Use Other Skills' so the handoffs are actionable.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is consistently lean and directive — nearly every bullet is an API name plus a one-line rule (e.g., "Use `ToolbarSpacer` to communicate grouping"). It assumes SwiftUI competence and never explains basics. It is not a 5 because some rules stay slightly abstract (e.g., "Make most of the app's content discoverable from search", "Validate that glass grouping... are visually coherent") which add tokens without adding executable instruction, and the 'Overview' section repeats content that appears later in 'App Structure' and 'Guardrails'. | 4 / 5 |
Actionability | Nearly every bullet names a concrete, real API to apply: `backgroundExtensionEffect`, `ToolbarSpacer`, `sharedBackgroundVisibility`, `searchToolbarBehavior`, `scrollEdgeEffectStyle`, `buttonBorderShape`, `neutralValue`, `ticks`, `containerConcentric`, `glassEffect(... .interactive())`, `glassEffectID`. This is an instruction-only skill and the guidance is specific and actionable. It is not a 5 because there are no code examples of the trickier APIs (glassEffect with a custom shape, glassEffectID morphing) — a short snippet for the two or three non-obvious cases would make the guidance copy-paste ready. | 4 / 5 |
Workflow Clarity | A 6-step workflow is clearly sequenced (identify structural pattern → remove fighting backgrounds → update standard structure first → add custom glass last → validate → launch properly), reinforced by a 'Review Checklist' section. Checkpoints are present: step 2 (audit before adding), step 5 (validate visual coherence and keyboard usability), and the checklist. It is not a 5 because validation is stated as an abstract check ('validate that... are visually coherent') with no concrete verification method or error-recovery loop, and the odd workflow step 6 (build-run-debug handoff) is an aside rather than an integrated checkpoint. | 4 / 5 |
Progressive Disclosure | The body is well organized into scannable sections (Workflow, App Structure, Toolbars, Search, Controls, Custom Liquid Glass, Review Checklist, Guardrails, When To Use Other Skills) and stays a concise overview. No bundle files (references/, scripts/, assets/) exist and none are referenced, which is consistent with an instruction-only skill of this size. It is not a 5 because the 'When To Use Other Skills' section names four sibling skills (swiftui-patterns, view-refactor, appkit-interop, build-run-debug) without paths or links — navigation to related material is described but not actionable. | 4 / 5 |
Total | 16 / 20 Passed |