comprehensive validation of a change to ensure it is correct and ready for a pull request
70%
Does it follow best practices?
Run evals on this skill
Adds up to 20 points to the overall score
Passed
No findings from the security scan
Fix and improve this skill with Tessl
tessl review fix ./.claude/skills/validating-a-change/SKILL.mdThis skill is for validating that a change is correct, complete, and ready for a pull request. It orchestrates several other skills to systematically check formatting, review code, ensure test coverage, and run tests.
This skill involves a lot of work. Consider splitting it into pieces and running each step as a subagent. Keep each subagent focused on a moderate amount of work so it doesn't get lost or wander off track.
Critical principle: Each step must fully resolve its own issues before proceeding to the next step. There is no need to restart from the beginning when issues are found—fix them in place and continue forward.
The ordering prioritizes:
Before starting validation, gather the following information (if running as a subagent, the invoking agent should provide these; otherwise, determine them yourself or ask the user):
Goal of the change: What is the change trying to accomplish? This is needed for high-level code review.
Type of change: Is this a new feature, bug fix, refactor, or performance change? This is needed for the adding-tests step.
Bug/issue reference (if applicable): For bug fixes, the issue number.
Any specific concerns (optional): Areas wanting extra attention.
If invoking as a subagent, the prompt should include: "Validate change for: . Change type: . "
This skill composes several other skills:
low-level-code-review - for mechanical code reviewhigh-level-code-review - for semantic code reviewadding-tests - for analyzing and adding test coveragerunning-tests - for running tests at all levelsrunning-make-to-build - for building correctlyconfiguring-the-build - for setting up different configurationsExecute these steps in order. Each step should fully resolve any issues it finds before proceeding to the next step.
Consider running as a subagent using the high-level-code-review skill.
Before launching, determine the git range:
git diff and git diff --cachedgit diff master...HEADLaunch with prompt: "Review the change for: . Get the diff
using <git-command>. "
This reviews the change for semantic correctness, design consistency, and completeness. The subagent will return a report of issues by severity.
If any Critical or Major issues are found, run a subagent to fix them before proceeding. Minor issues and Suggestions can be addressed or deferred at your discretion.
Consider running as a subagent using the low-level-code-review skill.
Launch with prompt: "Review the diff from <git-command>"
This reviews the diff for small, mechanical coding mistakes that don't require high-level understanding. The subagent will return a worklist of issues.
If any issues are found, run a subagent to fix them before proceeding.
Consider running as a subagent using the adding-tests skill.
Launch with prompt: "Analyze and add tests for: .
Get the diff using <git-command>. "
This analyzes the change to determine what tests are needed and adds them. The subagent will return a report of tests added.
Consider running as a subagent using the running-tests skill.
Before launching, identify the changed files/modules from the diff.
Launch with prompt: "Run tests through full suite for changes in <files/modules>."
This runs tests at levels 1-3: smoke tests, focused tests, and the full unit test suite. The subagent will return a detailed report of results.
If any tests fail, run a subagent to fix the issues before proceeding.
Consider running as a subagent using the running-tests skill with extended levels.
Launch with prompt: "Run tests through sanitizers for changes in <files/modules>. Include fuzz tests if protocol-critical code was changed."
This runs tests at levels 4-6: sanitizer builds (ASan, TSan, UBSan), extra
checks build, and randomized/fuzz tests. See the configuring-the-build skill
for details on configuration options.
Also verify the build succeeds with --disable-tests (the production config).
If any configuration fails to build or any tests fail, run a subagent to fix the issues before proceeding.
Run make format to auto-format all source code and verify formatting is clean.
When all steps pass without requiring any code edits, the change is validated and ready for a pull request. Summarize your work as follows:
If validation cannot be completed (e.g., stuck in a loop), report:
If invoked as a subagent, pass this summary back to the invoking agent.
stellar/stellar-core
f2b9194
If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.