testing-best-practices

Laravel test design and review. Use when selecting coverage, naming or structuring tests, choosing assertions or test data, isolating dependencies, testing HTTP or security boundaries, improving suite performance, or reviewing test value. Use framework guidance or search-docs for Pest and PHPUnit syntax.

Quality

81%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide

Securityby

Low

Low-risk findings worth noting

Quality

Content

67%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

The SKILL.md body is concise, actionable, and clearly sequenced, and its progressive-disclosure design is textbook. However the design is undermined by a broken bundle: every referenced rule file is missing, so the skill's core value ("Read every selected rule file") cannot be executed.

Suggestions

Ship the missing rule files (rules/finding-features.md, naming.md, assertions.md, endpoint-tests.md, test-data.md, isolation.md, security.md, performance.md, review.md) so the Rule Index links resolve.

Replace or remove the pinned "PHPUnit 11.5.55" version, or move version-specific guidance into a deprecated/old-patterns section, to avoid time-sensitive staleness.

Add a brief fix-and-retry loop in "How to Apply" for when tests fail (e.g., fix the code or test, rerun the minimal set, repeat until passing) to make the workflow's validation explicit.

Dimension	Reasoning	Score
Conciseness	Largely lean and directive with no over-explanation of concepts Claude knows, but the pinned version "PHPUnit 11.5.55" is time-sensitive outside any deprecated section (a rubric conciseness penalty) and a few meta-sentences ("Each rule file explains what to do and why") could be trimmed.	4 / 5
Actionability	As an instruction-only skill it gives concrete, specific directives and a clear procedure plus a real documentation URL, but provides no inline test code examples and delegates actionable detail to rule files that are not present in the bundle.	4 / 5
Workflow Clarity	The five-step "How to Apply" sequence is clear with explicit checkpoints ("The tests must pass", "Resolve every mismatch before completion"), though the fix-and-retry feedback loop on test failure is only implied rather than spelled out.	4 / 5
Progressive Disclosure	The body is well structured as an overview with a clearly signaled one-level-deep Rule Index table, but none of the nine referenced files (rules/finding-features.md, naming.md, assertions.md, endpoint-tests.md, test-data.md, isolation.md, security.md, performance.md, review.md) exist in the bundle, so every reference is a dead link and the disclosure does not actually function.	2 / 5
	Total	14 / 20 Passed

Description

88%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

A well-crafted description that clearly states what the skill does and gives a rich, concrete set of "Use when" triggers in third person. Minor room to add common synonyms and reduce overlap with generic review skills.

Dimension	Reasoning	Score
Specificity	Lists multiple concrete actions — "selecting coverage, naming or structuring tests, choosing assertions or test data, isolating dependencies, testing HTTP or security boundaries, improving suite performance, or reviewing test value" — giving comprehensive coverage of the Laravel testing domain.	5 / 5
Completeness	Explicitly answers both "what" ("Laravel test design and review") and "when" (a detailed "Use when..." clause with concrete trigger phrases), matching the anchor for clearly answering both with concrete triggers.	5 / 5
Trigger Term Quality	Good natural keyword coverage ("naming tests", "test data", "isolating dependencies", "suite performance", "HTTP"/"security boundaries") plus framework names (Pest, PHPUnit), but lacks common synonyms such as "unit/feature test", "mocks/test doubles", or "factories".	4 / 5
Distinctiveness Conflict Risk	Has a clear Laravel-testing niche with distinct triggers, but the "reviewing test value" trigger creates minor overlap risk with general code-review or generic testing skills.	4 / 5
	Total	18 / 20 Passed

Validation

87%

Warnings & errors only

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 14 / 16 Passed

Validation for skill structure

Criteria	Description	Result
metadata_version	'metadata.version' is missing	Warning
relative_links	Relative link issues: 9 missing	Warning

	Total	14 / 16 Passed

Repository: yaojingang/GEOFlow
Path: .agents/skills/testing-best-practices/SKILL.md
Commit: d7f601d

Reviewed: 8 days ago

Table of Contents

Discovery Implementation Validation

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.