Content
72%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A well-organized, token-efficient review constitution with concrete tooling and classification guidance. Its main weaknesses are missing validation feedback loops in the workflow and dangling references to bundle files that are not actually provided.
Suggestions
Add an explicit validation step to the workflow (e.g., 'Re-run clang-tidy/sanitizers to confirm each proposed fix actually resolves the finding before reporting it').
Either ship the referenced files (references/concurrency.md, references/error-handling.md, references/templates.md, references/performance.md, references/lifetime.md, references/rule-map.md, GOTCHAS.md, templates/phase0-starter.md) or remove the dangling references from the body.
Provide concrete clang-tidy invocation examples (e.g., a sample command with relevant checks) rather than only naming the tool.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is lean and assumes Claude's competence: tight ordered lists, no textbook explanations of C++ concepts, and every section earns its place. Only minor editorializing ("not from textbooks") keeps it from feeling padded. | 5 / 5 |
Actionability | Concrete, executable guidance is present throughout (ordered review priority, specific tooling like compile_commands.json and clang-tidy, an ownership classification scheme, and severity-bucketed output), but tool invocations lack specific flags/commands. | 4 / 5 |
Workflow Clarity | Sequenced steps exist (Review Priority 1-8, Tool First discovery, Modernization Discipline ordering), but there are no explicit validation checkpoints or validate-fix-retry feedback loops for confirming findings are correct before reporting. | 3 / 5 |
Progressive Disclosure | Structure and condition-signaled one-level references are well designed ("If project has concurrency → read references/concurrency.md"), but the referenced files (references/*.md, GOTCHAS.md, templates/phase0-starter.md) do not exist in the bundle, so the navigation is broken in practice. | 3 / 5 |
Total | 15 / 20 Passed |