Content
81%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A well-engineered, highly actionable skill body: the canonical battery, anti-patterns table, and diagnosis loop give Claude concrete, executable guidance with genuine validation checkpoints. The main gaps are semi-skeletal code in a few tests (undefined helpers) and a two-level reference chain that leaves several bundle files undiscoverable from the body.
Suggestions
Make Tests 4, 8, and 9 self-contained: define or import the helpers they rely on (sign_jwt, enqueue_export, run_job, app) or replace Test 8's inspect.getsource introspection with a concrete assertion against a fixture route, so every snippet in the canonical battery is copy-paste runnable.
Surface the second-level reference files directly from SKILL.md — e.g., add one-line pointers to create-policy-syntax.md, policy-and-bypass-patterns.md, tenant-context-patterns.md, and the per-engine files (mysql-mariadb.md, sqlserver.md, cockroachdb.md, vitess.md) in the References section — so all bundle files are discoverable one level deep.
Trim incidental commentary (e.g., the 404-vs-403 trade-off aside and the Test 8 explanation) or fold it into the anti-patterns table, which already carries similar guidance more compactly.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is dense with tables, executable code, and brief high-value commentary (e.g., the non-obvious fact that FK and UNIQUE checks bypass RLS), with almost no explanation of concepts Claude already knows. Minor trimming is possible — some test commentary ("The trade-off: debugging slightly harder", the Test 8 inline explanation) and the somewhat long Test 8/9 snippets could be tightened — so it sits at the score-4 anchor rather than 5. | 4 / 5 |
Actionability | Ten concrete pytest snippets, a role-verification SQL query, and a paste-ready GitHub Actions workflow make the guidance mostly executable. It falls short of score 5 because Tests 4, 8, and 9 depend on undefined helpers (sign_jwt, enqueue_export, run_job, app) and Test 8's source-introspection assertion is closer to a sketch than runnable code. | 4 / 5 |
Workflow Clarity | The sequence is explicit and well-validated: the planning phase produces concrete committed artifacts, Steps 1–3 build and gate the suite (with SQL verification of the connection role and a merge-blocking CI job), and Step 4 is a full diagnosis feedback loop ending in "Write the minimal regression test before fixing". This matches the score-5 anchor's explicit validation steps and error-recovery loop. | 5 / 5 |
Progressive Disclosure | The body is a clear overview with well-signaled, real references (isolation-models, attack-patterns, framework-skeletons, row-level-security, other-engines) all one link away. It falls short of the score-5 one-level-deep ideal because reference files chain to a second level (row-level-security.md → create-policy-syntax.md, policy-and-bypass-patterns.md, tenant-context-patterns.md; other-engines.md → per-engine files), and only 5 of the 14 bundle files are surfaced directly from SKILL.md, making the rest harder to discover. | 4 / 5 |
Total | 17 / 20 Passed |