Content
85%Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A tightly structured, highly actionable procedural skill that walks through lock-order convention, instrumentation, graph-based cycle detection, timeouts, TSan, postmortem analysis, and fingerprinting with executable code and validation at each step. The only weakness is mild verbosity from explaining a deadlock concept Claude already knows.
Suggestions
Remove or compress the opening deadlock definition ('A deadlock = a cycle in the lock-wait graph: thread A holds X waiting for Y...'); Claude already knows what a deadlock is, so lead directly with the harness method.
Tighten the redundant framing line ('Tests prevent deadlocks via static analysis of lock acquisition order + runtime detection') since the numbered Step 1–8 list that follows already conveys this.
Fold Step 2's 'rough sketch using contextvars + decorator' caveat into a one-line note so the section reads as authoritative rather than provisional.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Mostly efficient and code-dense, but it opens by defining a deadlock ("A deadlock = a cycle in the lock-wait graph: thread A holds X waiting for Y; thread B holds Y waiting for X") — a concept Claude already knows — and re-states the method, so it could be tightened per the 'penalize concepts Claude knows' guideline. | 2 / 3 |
Actionability | Each step ships real, executable Python (OrderedLock, build_lock_graph, find_cycles, fingerprint_acquire, timed-acquire test) plus concrete commands (TSAN_OPTIONS=detect_deadlocks=1, jstack, gdb thread apply all bt), matching the copy-paste-ready anchor. | 3 / 3 |
Workflow Clarity | Eight numbered steps give a clear sequence, and each step embeds an assertion-based test (assert cycles == [], assert acquired, assert len(fps) <= 5) as an explicit validation checkpoint, with an anti-patterns table serving as a checklist. | 3 / 3 |
Progressive Disclosure | No bundle files exist; the body is well-organized into sequenced sections with clearly signaled one-level-deep external references (the [TSan docs] link and sibling skills race-condition-test-author / async-ordering-tests), avoiding nested or poorly-signaled references. | 3 / 3 |
Total | 11 / 12 Passed |