Content
75%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A well-executed dispatcher skill: executable scripts, explicit tier-cost rationale, an anti-patterns table with concrete fixes, and a rare explicit validation warning against false-positive aggregation. It falls short of top marks on minor gaps — an undefined run-tests.sh hook, inline time-sensitive device data, and everything packed into one file rather than split into references.
Suggestions
Define or stub ./scripts/run-tests.sh (even a two-line signature showing how target name and capabilities JSON are consumed) — it is the hook every CI shard invokes but is never shown.
Trim the full 14-device release-tier YAML to representative entries plus a note, and flag device/OS versions as example data that the owning team refreshes — the inlined version numbers (iPhone 15, os 17.4, api 34) will age quickly.
Move the per-farm wiring (Step 5's Firebase/BrowserStack snippets) into a references/ file (e.g. references/farm-wiring.md) linked from the main body, keeping SKILL.md as the decision-level overview.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Mostly lean: code blocks carry the weight, the anti-patterns table is dense, and the farm-vs-local decision table is compact and useful. Not 5 because of minor trimmable content — the full 14-device release-tier YAML listing, the test-pyramid citation ('mobile UI tests are the most expensive layer') explaining a concept Claude already knows, and time-sensitive version/device data (iPhone 15, os 17.4, api 34) inlined rather than isolated as aging example data. | 4 / 5 |
Actionability | gen-matrix.py and aggregate-matrix.py are complete, executable scripts; the GitHub Actions matrix/dispatch YAML and the gcloud/BrowserStack commands are concrete. Not 5 because of minor gaps: ./scripts/run-tests.sh (the hook the whole CI matrix calls) is never defined, and the reusable run-matrix.yml is only shown as a jobs fragment; not 3 because the guidance is genuinely executable, not pseudocode. | 4 / 5 |
Workflow Clarity | Clear 5-step sequence (define matrix → generate capabilities → tier dispatch → aggregate → farm-vs-local decision), and the batch aggregation risk gets an explicit checkpoint ('a shard that fails to upload its JUnit XML... reads as 0 tests, not failure — detect shards with a missing or empty report, re-run only those shards, then re-aggregate'), which satisfies the batch-operation feedback-loop requirement. Not 5 because minor validation gaps remain — no check that the generated matrix output is well-formed or that a tier's device list is non-empty before dispatch. | 4 / 5 |
Progressive Disclosure | No bundle files exist; the single file is well-organized with clear section headers, a When-to-use section, per-step structure, anti-patterns, and a References section naming sibling skills. Not 5 because all content lives inline in one ~280-line file — the full tier YAML listing and per-farm wiring are natural candidates for separate reference files; not 3 because structure and organization are genuinely good, not merely 'some structure'. | 4 / 5 |
Total | 16 / 20 Passed |