Content
81%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A well-engineered, operationally dense skill body: sequenced steps with real validation and feedback loops, concrete code and commands, and an appropriately split one-level reference file for framework-specific detail. The main residual issues are minor — a few passages re-explaining git semantics Claude already knows, code fragments with unhandled paths, and a script-path comment pointing at a nonexistent file.
Suggestions
Trim the three-dot vs two-dot git diff explanation in Step 3 to a one-line reminder ('use ..., not .. — matches PR semantics') since Claude already knows diff-dot semantics; the anti-patterns table already covers the failure mode.
Complete the select_tests snippet so the ('FALLBACK', f) return is consumed (e.g. show the caller mapping it to the full-suite run), or note explicitly that the fallback is handled by the CI workflow in the reference file.
Fix the "# scripts/build_test_map.py" comment to match the actual bundle layout — the function is inline in SKILL.md and no scripts/ directory exists.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is dense and lean — every section carries new operational content (fallback triggers, map inversion code, anti-patterns table) with no filler. Falls short of 5 because a few passages explain things Claude already knows, e.g. the three-dot vs two-dot git diff semantics lecture ("Three-dot diff is 'what changed on this branch since it diverged from main'...") and the Azure HTML/CSS aside. | 4 / 5 |
Actionability | Concrete, executable guidance dominates: real Python for build_map and select_tests, exact git commands with the correct three-dot syntax, a hard-coded fallback file list (pom.xml, package.json, Cargo.toml, Dockerfile), and a ready PR-comment template. Not 5: the snippets are fragments (no imports shown, the ('FALLBACK', f) return path is never handled) and the runnable CI workflow is deferred to the reference file. | 4 / 5 |
Workflow Clarity | Seven clearly sequenced steps with explicit validation (Step 5's shadow full-suite run and T1/T2 comparison pattern), a genuine feedback loop ("Failures that didn't appear in PR runs reveal selection misses; investigate and update the map"), and the anti-patterns table serving as a checklist. Test selection is not destructive, and validation checkpoints are present regardless. | 5 / 5 |
Progressive Disclosure | Good structure with a real, one-level-deep references/instrumentation-and-ci.md that is clearly signaled at both use sites ("Per-framework recipes ... live in references/instrumentation-and-ci.md"). Not 5: the code comment "# scripts/build_test_map.py" implies a script file that does not exist in the bundle (there is no scripts/ directory), a minor navigation gap. | 4 / 5 |
Total | 17 / 20 Passed |