Name: testland/test-code-conventions
Rating: 88 (1 reviews)
Author: testland

testland/test-code-conventions

Pure-reference catalog of test-code conventions: AAA structure (Arrange / Act / Assert), per-test single-responsibility, descriptive naming (`{sut}_{scenario}_{expected}`), assertion specificity, mocking rationale (state vs behavior, fake vs mock), fixture-coupling rules, the magic-number / hard-coded-string anti-patterns, and step design (§11: FIRST principles, step granularity, the mechanical → page → business abstraction layers, the rule-of-three extraction heuristic, declarative phrasing); the E2E selector-priority, web-first-assertion, and step-grouping conventions live in references/. Use as the shared rule book a test-code review cites back to, or as onboarding for what makes a test code-reviewable; to score a test's quality on weighted axes use test-design-scorecard, and for setup/teardown isolation specifically use test-isolation-patterns.

Quality

88%

Does it follow best practices?

Impact

—

Average score across 10 eval scenarios

Securityby

Passed

No findings from the security scan

Quality

Content

78%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

A well-structured, actionable reference catalog with strong progressive disclosure and concrete examples throughout. Its main weakness is verbosity where it restates widely-known concepts (the Fowler test-double taxonomy, the FIRST acronym) instead of citing them.

Suggestions

In §5, replace the five Fowler block-quote definitions of dummy/fake/stub/spy/mock with a one-line summary plus the existing citation; Claude already knows this taxonomy.

In §11 FIRST principles, condense the acronym walkthrough to the rule and citations rather than re-explaining each letter Claude already knows.

Tighten the §2 and §3 prose around the code blocks; the examples already carry the message and the surrounding explanation partly restates them.

Dimension	Reasoning	Score
Conciseness	The bulk is valuable team-specific convention and rationale, but the five Fowler block quotes defining dummy/fake/stub/spy/mock (§5) and the FIRST-principles acronym explanation (§11) restate concepts Claude already knows and could be tightened.	3 / 5
Actionability	Concrete executable TypeScript examples, vague-vs-specific comparison tables, and a full before/after worked example with a per-convention finding→fix table give copy-paste-ready, specific guidance.	5 / 5
Workflow Clarity	A clear 7-step 'How to use' review sequence plus an end-to-end worked example, but no explicit validate/checkpoint steps (acceptable since the skill is non-destructive, so not a 3-cap).	4 / 5
Progressive Disclosure	A concise overview spine splits E2E and step-grouping detail into two clearly signaled, one-level-deep reference files (both verified to exist), with easy link-based navigation.	5 / 5
	Total	17 / 20 Passed

Description

92%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

A strong, comprehensive description that clearly states both what the skill is and when to use it, with concrete convention enumeration and explicit disambiguation from sibling skills. It is slightly jargon-heavy in its trigger phrasing.

Dimension	Reasoning	Score
Specificity	Enumerates many concrete conventions — AAA, single-responsibility, naming (`{sut}_{scenario}_{expected}`), assertion specificity, mocking rationale, fixture coupling, magic-number anti-patterns, step design — giving comprehensive coverage rather than minor gaps.	5 / 5
Completeness	Explicit 'what' (the catalog of conventions) and explicit 'when' ('Use as the shared rule book a test-code review cites back to, or as onboarding for what makes a test code-reviewable') with concrete trigger phrases.	5 / 5
Trigger Term Quality	Natural terms like 'test-code review' and 'onboarding' are present, but the phrasing is jargon-heavy and leans on section labels (§11), missing a few common synonyms a user would naturally say.	4 / 5
Distinctiveness Conflict Risk	Clear niche as a test-code conventions rule book, with explicit disambiguation pointers to sibling skills (test-design-scorecard, test-isolation-patterns) minimizing conflict risk.	5 / 5
	Total	19 / 20 Passed

Validation

100%

Warnings & errors only

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 16 / 16 Passed

Validation for skill structure

No warnings or errors.

Reviewed

3 days ago

Table of Contents

Discovery Implementation Validation