Content
75%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A highly actionable, well-structured pattern catalog with runnable code in three languages, concrete commands, and strong selection/anti-pattern tables. Its weaknesses are verbosity (definitions and canonical-source background for patterns Claude already knows) and a missing feedback loop after the random-order validation step, plus a monolithic single-file layout that could offload per-pattern detail to reference files.
Suggestions
Trim or collapse the 'Definition' paragraphs and canonical-source attributions for well-known patterns (Builder, Factory, Object Mother) into one-line pointers, keeping the anti-pattern tables and selection guide — the parts Claude cannot derive on its own — as the body's core.
Add a short error-recovery step after the random-order re-run (e.g., what to do when a test fails only in randomized order: how to trace the data dependency and which pattern to switch to), completing the validate → fix → retry loop.
Move per-pattern detail (cross-language equivalents, canonical references, extended examples) into per-pattern files under references/ and keep SKILL.md as the overview plus the pattern-selection guide and cross-cutting anti-patterns.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Mostly efficient — the anti-pattern and selection tables are dense with judgment — but it defines patterns Claude already knows ("A Test Data Builder is a class with chainable methods...", "A Factory is a registered, named template...", the Fowler quote) and carries a long References section, so it could be tightened; not level 2 since the padding is confined to definitions rather than pervasive. | 3 / 5 |
Actionability | Fully executable guidance: a runnable TypeScript builder, real FactoryBot and factory_boy code, concrete commands (`pytest --random-order`, `jest --randomize`), a grep-based inventory step, and a per-need decision table covering the common cases. | 5 / 5 |
Workflow Clarity | The four-step catalog process (Inventory → Pick → Check → Hand off) is clearly sequenced with a hard checkpoint ("Stop and fix any production data that is not anonymised before anything else") and a validation step (re-run the suite twice in random order), but there is no error-recovery guidance for what to do when that random-order re-run exposes cross-test data dependence, so it falls short of the feedback-loop anchor. | 4 / 5 |
Progressive Disclosure | Well-sectioned single-file catalog with clearly signaled, one-level-deep references (external URLs and named sibling skills, no nested chains), but ~300 lines of per-pattern detail (definitions, cross-language equivalents, canonical sources) are inlined in SKILL.md when they could be split into per-pattern reference files; fits 'good structure; minor organization gaps'. | 4 / 5 |
Total | 16 / 20 Passed |